Skip to content

Enforce API documentation#160

Open
pravic wants to merge 1 commit into
ClickHouse:mainfrom
pravic:patch-1
Open

Enforce API documentation#160
pravic wants to merge 1 commit into
ClickHouse:mainfrom
pravic:patch-1

Conversation

@pravic

@pravic pravic commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

Summary

Currently almost nobody documents added functions which is not good for the users of this library - but the API must have documentation.

Let's warn about missing docs (deny would be even better).

Comment thread src/lib.rs Outdated
Currently almost nobody documents added functions which is not good
for the users of this library - but the API must have documentation.

Let's warn about missing docs (deny would be even better).
@pravic

pravic commented Dec 4, 2024

Copy link
Copy Markdown
Contributor Author

Guys? @slvrtrn @loyd

More and more PRs are merged, but nobody cares about maintaining the API documentation.

@loyd

loyd commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator

More and more PRs are merged, but nobody cares about maintaining the API documentation.

I agree; we need to force the creation of documentation for all new extensions.
But we cannot just merge this PR and break CI. This check must be enabled, but only after adding all missing docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants