Skip to content

chore: bump root engines.node to >=20.19.0 to match ESLint v10#723

Merged
peter-leonov-ch merged 2 commits into
mainfrom
copilot/apply-feedback-from-pr-643
May 9, 2026
Merged

chore: bump root engines.node to >=20.19.0 to match ESLint v10#723
peter-leonov-ch merged 2 commits into
mainfrom
copilot/apply-feedback-from-pr-643

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 9, 2026

Summary

Applies review feedback from #643 (discussion_r3213961603): ESLint v10 requires Node ^20.19.0, but the root engines.node still advertises >=20, allowing 20.0–20.18 where ESLint v10 may not run reliably.

  • Bump root engines.node from >=20 to >=20.19.0 in package.json.

Other package.json files in the repo are unaffected — examples/{node,web} and tests/clickhouse-test-runner pin ESLint v9, and tests/clickhouse-test-runner already declares >=20.19.0.

Checklist

  • A human-readable description of the changes was provided to include in CHANGELOG

Agent-Logs-Url: https://github.com/ClickHouse/clickhouse-js/sessions/68d790d3-c9d1-4140-93ed-a35b3f3fbe3a

Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
@peter-leonov-ch peter-leonov-ch marked this pull request as ready for review May 9, 2026 22:18
@peter-leonov-ch peter-leonov-ch self-requested a review as a code owner May 9, 2026 22:18
Copilot AI review requested due to automatic review settings May 9, 2026 22:18
@peter-leonov-ch peter-leonov-ch requested a review from mshustov as a code owner May 9, 2026 22:18
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 9, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ peter-leonov-ch
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository root Node engine constraint to reflect the minimum Node version required by the root ESLint v10 toolchain, preventing installs on Node 20.0–20.18 where ESLint v10 may not run.

Changes:

  • Bump root package.json engines.node from >=20 to >=20.19.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@peter-leonov-ch peter-leonov-ch merged commit 088b3cb into main May 9, 2026
64 checks passed
@peter-leonov-ch peter-leonov-ch deleted the copilot/apply-feedback-from-pr-643 branch May 9, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants