chore: bump root engines.node to >=20.19.0 to match ESLint v10#723
Conversation
Agent-Logs-Url: https://github.com/ClickHouse/clickhouse-js/sessions/68d790d3-c9d1-4140-93ed-a35b3f3fbe3a Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
|
|
There was a problem hiding this comment.
Pull request overview
Updates the repository root Node engine constraint to reflect the minimum Node version required by the root ESLint v10 toolchain, preventing installs on Node 20.0–20.18 where ESLint v10 may not run.
Changes:
- Bump root
package.jsonengines.nodefrom>=20to>=20.19.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Applies review feedback from #643 (discussion_r3213961603): ESLint v10 requires Node
^20.19.0, but the rootengines.nodestill advertises>=20, allowing 20.0–20.18 where ESLint v10 may not run reliably.engines.nodefrom>=20to>=20.19.0inpackage.json.Other
package.jsonfiles in the repo are unaffected —examples/{node,web}andtests/clickhouse-test-runnerpin ESLint v9, andtests/clickhouse-test-runneralready declares>=20.19.0.Checklist