[client-v2] fixed hasValue to not throw exception#2758
Merged
Conversation
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
mzitnik
reviewed
Feb 25, 2026
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
Outdated
Show resolved
Hide resolved
mzitnik
approved these changes
Feb 25, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Fixes issue with hasValue when it throws exception for unknown column
Closes #2755
Checklist
Delete items not relevant to your PR:
Note
Low Risk
Small, localized behavior change to column lookup/
hasValue()with added integration coverage; minimal impact outside unknown-column checks.Overview
Fixes
hasValue()to returnfalseinstead of throwing when callers reference an unknown column name or an out-of-range column index.This adds non-throwing lookup helpers to
TableSchema(findColumnIndex,findColumnName) and updates both the binary reader (AbstractBinaryFormatReader) andMapBackedRecordto use them. An integration test is added to cover both binary-reader andqueryAllrecord paths with missing/nullable columns.Written by Cursor Bugbot for commit c0324b8. This will update automatically on new commits. Configure here.