Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
|
mzitnik
reviewed
Feb 25, 2026
| } | ||
|
|
||
|
|
||
| Properties disableSavingRoles = new Properties(); |
Contributor
There was a problem hiding this comment.
Do we support this syntax https://clickhouse.com/docs/sql-reference/statements/set-role
Contributor
Author
There was a problem hiding this comment.
If you mean
SET ROLE {DEFAULT | NONE | role [,...] | ALL | ALL EXCEPT role [,...]}
Then we support only:
SET ROLE NONE
SET ROLE role
SET ROLE DEFAULT- we need to test. I think, it is missingSET DEFAULT ROLE- we should skip because it configures user default role for user without setting to current.
mzitnik
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR:
Note
Medium Risk
Touches connection property parsing and SQL parsing behavior, which can subtly change session settings/roles handling across statements. Risk is mitigated by added integration coverage, but mis-parsing or unexpected property mapping could affect authentication/permissions at runtime.
Overview
Ports several legacy JDBC-v1 style properties into JDBC-v2 for compatibility. Adds
remember_last_set_roles(defaulttrue) to control whetherSET ROLE ...statements are parsed and persisted into client/session state;SqlParserFacadenow receivesJdbcConfigurationand conditionally extracts roles across all parser implementations.Adds deprecated
custom_settingsandcustom_http_paramsproperties and converts their comma-separatedk=vpairs into clientserverSetting(...)options duringJdbcConfigurationinit. Also reintroduces deprecated no-op compatibility keys (use_server_time_zone_for_dates,http_connection_provider) and updates integration tests to cover old custom settings passthrough and role behavior across parser choices (including disabling role remembering).Written by Cursor Bugbot for commit eb04fa7. This will update automatically on new commits. Configure here.