You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Touches request settings serialization for max_execution_time, which can change query timeout behavior and could impact callers relying on previous (incorrect) handling; scope is small and covered by unit+integration tests.
Overview
Ensures QuerySettings#setMaxExecutionTime is encoded as a server setting (using ClientConfigProperties.serverSetting(...)) instead of a plain option, and updates getMaxExecutionTime to read/parse the prefixed value.
Adds ServerSettings.MAX_EXECUTION_TIME constant, updates unit tests to assert the stored prefixed setting, and introduces an integration test that verifies a long-running query is aborted with ClickHouse TIMEOUT_EXCEEDED (code 159) when max_execution_time is set.
Written by Cursor Bugbot for commit 867ed75. This will update automatically on new commits. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed sending max_execution_time in query settings as server setting.
Closes #2750
Checklist
Delete items not relevant to your PR:
Note
Medium Risk
Touches request settings serialization for
max_execution_time, which can change query timeout behavior and could impact callers relying on previous (incorrect) handling; scope is small and covered by unit+integration tests.Overview
Ensures
QuerySettings#setMaxExecutionTimeis encoded as a server setting (usingClientConfigProperties.serverSetting(...)) instead of a plain option, and updatesgetMaxExecutionTimeto read/parse the prefixed value.Adds
ServerSettings.MAX_EXECUTION_TIMEconstant, updates unit tests to assert the stored prefixed setting, and introduces an integration test that verifies a long-running query is aborted with ClickHouseTIMEOUT_EXCEEDED(code159) whenmax_execution_timeis set.Written by Cursor Bugbot for commit 867ed75. This will update automatically on new commits. Configure here.