You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Low Risk
Adds only TestNG unit tests for Array(Nullable(...)) decoding; no production logic is changed, so risk is limited to potential test flakiness or incorrect assertions.
Overview
Adds ClickHouseBinaryFormatReaderNullableArrayTest to expand unit coverage for Array(Nullable(...)) decoding in RowBinaryWithNamesAndTypesFormatReader.
The new tests build RowBinaryWithNamesAndTypes payloads and assert correct handling of null elements, empty arrays, and all-null arrays when accessed via both column name and 1-based index using getObjectArray(...) and getList(...) (covering Int32, Int64, String, Bool, and Float64).
Written by Cursor Bugbot for commit 44f1a59. This will update automatically on new commits. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding extra nullable array tests. Adding to PR #2747
Checklist
Delete items not relevant to your PR:
Note
Low Risk
Adds only TestNG unit tests for
Array(Nullable(...))decoding; no production logic is changed, so risk is limited to potential test flakiness or incorrect assertions.Overview
Adds
ClickHouseBinaryFormatReaderNullableArrayTestto expand unit coverage forArray(Nullable(...))decoding inRowBinaryWithNamesAndTypesFormatReader.The new tests build RowBinaryWithNamesAndTypes payloads and assert correct handling of null elements, empty arrays, and all-null arrays when accessed via both column name and 1-based index using
getObjectArray(...)andgetList(...)(coveringInt32,Int64,String,Bool, andFloat64).Written by Cursor Bugbot for commit 44f1a59. This will update automatically on new commits. Configure here.