Add PageUp and PageDown support for slide navigation#227
Merged
alxlion merged 1 commit intoJun 5, 2026
Merged
Conversation
Contributor
|
Thanks for your contribution 🙏 |
alxlion
added a commit
that referenced
this pull request
Jun 5, 2026
commit 7db48f5 Author: Alex Lion <dev@alexandrelion.com> Date: Fri Jun 5 10:16:10 2026 +0200 Update changelog commit 3039b70 Author: Peter Rundqvist <47314226+pete1854@users.noreply.github.com> Date: Fri Jun 5 10:11:07 2026 +0200 Add swedish translation (#228) * Initial translation * Initial error msg translation * Fixes suggested by Copilot. * Fixed spacing before ! and ? * Added missing provider translation. * Upddated translation for "Unpin" * Added missing Content-Type header. commit d18e5d7 Author: fgallarday <fgallarday@users.noreply.github.com> Date: Fri Jun 5 03:07:25 2026 -0500 Add PageUp and PageDown slide navigation support (#227) commit 24e18c2 Author: Alex Lion <dev@alexandrelion.com> Date: Fri Jun 5 10:06:54 2026 +0200 Bump version to 2.5.2 commit d5df9a7 Author: Alex Lion <dev@alexandrelion.com> Date: Fri May 8 22:42:04 2026 +0200 Fix form submissions losing values when field names contain spaces or non-word characters commit 5759695 Author: Alex Lion <dev@alexandrelion.com> Date: Fri May 8 14:50:33 2026 +0200 Update package-lock.json: add asset name, upgrade dependencies, and remove unused packages commit e246530 Author: Alex Lion <dev@alexandrelion.com> Date: Fri May 8 14:34:53 2026 +0200 Bump version to 2.5.1 commit 534d915 Author: Alex Lion <dev@alexandrelion.com> Date: Fri May 8 10:55:38 2026 +0200 Handle Ecto.NoResultsError in event retrieval and redirect with error message commit b762e21 Author: Alex Lion <dev@alexandrelion.com> Date: Fri May 8 10:47:01 2026 +0200 Fix crash on event manager pages when an event has multiple activity leaders commit 153cadb Author: alxlion <dev@alexandrelion.com> Date: Wed Apr 29 13:42:05 2026 +0000 Fix presentation views without slide count commit 3cfb3ca Author: alxlion <dev@alexandrelion.com> Date: Wed Apr 29 13:16:48 2026 +0000 Fix event code normalization validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
PageUpandPageDownkeyboard events for slide navigation.This improves compatibility with common wireless presentation clickers, which often emit
PageDownto advance slides andPageUpto go back.Supported navigation keys after this change:
ArrowLeft,PageUpArrowRight,PageDownChanges
assets/js/manager.jsto handlePageUpandPageDown.assets/js/presenter.jsto translatePageUp/PageDowninto the existingArrowLeft/ArrowRightnavigation events sent to the opener window.Testing
Manual validation checklist:
ArrowRight: advances to next slide.ArrowLeft: returns to previous slide.PageDown: advances to next slide.PageUp: returns to previous slide.PageDownfrom presenter view: advances slide in manager/presentation.PageUpfrom presenter view: returns to previous slide.Automated checks performed:
mix test— not executed: Elixir/Mix is not installed in the local environment. The change is limited to two JavaScript files with no Elixir/Phoenix backend logic, so there are no relevant Elixir unit tests for this diff.assets/package.json(only adeployscript exists).Notes
This PR targets the
devbranch, following the repository contribution instructions.The change is backward-compatible: existing
ArrowLeft/ArrowRightnavigation remains unchanged.Both
manager.jsandpresenter.jsalready contain an input guard (e.target.tagName != "input") that prevents keyboard navigation from interfering with text fields — this guard was not modified.This contribution is submitted from the public organizational fork
ATuManera/Claper, with commit authorship byJ. Fernando Gallarday <fernando@gallarday.net>.