Skip to content

Skimage no upper bound#132

Closed
afermg wants to merge 6 commits into
CellProfiler:masterfrom
afermg:skimage_no_upper_bound
Closed

Skimage no upper bound#132
afermg wants to merge 6 commits into
CellProfiler:masterfrom
afermg:skimage_no_upper_bound

Conversation

@afermg

@afermg afermg commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

We ideally want to be able to support py313 in cp_measure, for that we ought to remove the upper bound on scikit-image that I placed a while ago. The reasoning behind it was that above scikit image 0.24 do not support python 3.9. I tested that it seems fine to relax the constraints. All but one test run, but I will try to fix it.

======================== short test summary info ============================================
FAILED tests/test_cpmorphology.py::TestWhiteTophat::test_01_04_random - ValueError: The binary mode of fromstring is removed, use frombuffer instead
======================================================================================================== 
1 failed, 506 passed, 2 skipped, 50 warnings in 50.46s 

@afermg
afermg marked this pull request as draft October 21, 2025 15:45
@afermg

afermg commented Oct 21, 2025

Copy link
Copy Markdown
Contributor Author

After a minor update to the tests we have no errors:

$pytest
...
507 passed, 2 skipped, 50 warnings in 43.39s 

@gnodar01

Copy link
Copy Markdown
Member

Thanks! Closing, but commits cherry-picked to PR #134

@gnodar01 gnodar01 closed this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants