feat(settlement): return semantic errors for batch validation failures#766
Merged
greatest0fallt1me merged 1 commit intoJul 26, 2026
Conversation
|
@datagerl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace generic batch validation panics with typed settlement contract errors
add focused tests for empty, oversized, and non-positive batches
update settlement error docs and error-code coverage
Changes
introduce BatchEmpty and BatchTooLarge settlement errors
return AmountNotPositive for non-positive batch amounts
add regression tests for invalid batch inputs
document the new visible error behavior
Testing
verified editor diagnostics for the touched Rust files note: full cargo test could not be executed in this environment because the Rust toolchain was unavailable on PATH
Closes #732