Skip to content

feat(settlement): return semantic errors for batch validation failures#766

Merged
greatest0fallt1me merged 1 commit into
CalloraOrg:mainfrom
datagerl:feat/settlement-batch-error-variants
Jul 26, 2026
Merged

feat(settlement): return semantic errors for batch validation failures#766
greatest0fallt1me merged 1 commit into
CalloraOrg:mainfrom
datagerl:feat/settlement-batch-error-variants

Conversation

@datagerl

Copy link
Copy Markdown
Contributor

Summary
replace generic batch validation panics with typed settlement contract errors
add focused tests for empty, oversized, and non-positive batches
update settlement error docs and error-code coverage
Changes
introduce BatchEmpty and BatchTooLarge settlement errors
return AmountNotPositive for non-positive batch amounts
add regression tests for invalid batch inputs
document the new visible error behavior
Testing
verified editor diagnostics for the touched Rust files note: full cargo test could not be executed in this environment because the Rust toolchain was unavailable on PATH

Closes #732

@drips-wave

drips-wave Bot commented Jul 26, 2026

Copy link
Copy Markdown

@datagerl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@greatest0fallt1me
greatest0fallt1me merged commit 78bcef1 into CalloraOrg:main Jul 26, 2026
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add contract-error enum expansion for batch_claim

2 participants