squid:S1943 - Classes and methods that rely on the default system enc…#10
Open
m-ezzat wants to merge 1 commit into
CalebFenton:masterfrom
DevFactory:release/classes-and-methods-that-rely-on-the-default-system-encoding-should-not-be-used-fix-1
Open
squid:S1943 - Classes and methods that rely on the default system enc…#10m-ezzat wants to merge 1 commit intoCalebFenton:masterfrom DevFactory:release/classes-and-methods-that-rely-on-the-default-system-encoding-should-not-be-used-fix-1
m-ezzat wants to merge 1 commit into
CalebFenton:masterfrom
DevFactory:release/classes-and-methods-that-rely-on-the-default-system-encoding-should-not-be-used-fix-1
Conversation
…oding should not be used
Contributor
Author
|
I am not sure whether you do not agree with these changes or not. Please close this PR if not. |
Owner
|
I'll be up front: I'm not 100% sure this code won't break something, and this project is essentially dead, so it'll take a rainy day before I can test + merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule squid:S1943 - Classes and methods that rely on the default system encoding should not be used
You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S1943
Please let me know if you have any questions.
M-Ezzat