BB2-3914: Ensure headers are displayed properly#109
Conversation
jimmyfagan
left a comment
jimmyfagan
left a comment
There was a problem hiding this comment.
Looks great, my one question is whether or not we should eliminate usage of the h1, h2, etc in general instead of adding the revert in the css. If I'm understanding this correctly they'd have the same impact, but that might be a little more straightforward to not use revert.
But either way, this looks good when I run locally, so I'll mark this as approved, let me know if you decide to make a change and I can re-run and re-review.
After removing the h1/h2 tags and rebuilding locally, the formatting is off again: 
So I will merge it as is. From what I understand, the CSS revert rolls back the cascading styling, so the modified style rules from the design-system repo are now blocked on h1-h6 tags because we have that revert on font-size/margin-block. Screenshot below shows the dev console, and how having revert in there blocks the 
|
2 participants
JIRA Ticket:
BB2-3914
What Does This PR Do?
Fixes the formatting of headers. The formatting was no longer correct after this merge.
The formatting was no longer correct after we updated the version of the CMS design system repo that we were using. When that update was performed, we also changed what styling files we were importing from the CMS design system repo, causing this formatting issue. Specifically, we updated from version 2.7.3 to 10.1.3 of this repository.
What Should Reviewers Watch For?
Ensure the formatting now looks correct.
If you're reviewing this PR, please check for these things in particular:
Validation
Pull this branch and build the project. Got to localhost:3000 in your browser and confirm the formatting matches the second screenshot in the ticket description.