fix: Inline validation for empty and duplicate tags in Tag Editor by mulikruchi07 · Pull Request #586 · CCExtractor/taskwarrior-flutter

mulikruchi07 · 2026-02-09T17:58:40Z

Description

This PR introduces validation and displays clear inline error messages:

"Please enter a tag" when the input is empty
"Tag already exists" when the user tries to add a duplicate tag
Support comma-separated tag input (e.g. "t1, t2")
Ensure tags are saved correctly when adding/editing tasks

The dialog now remains open until a valid tag is submitted.

Fixes #518

Screenshots

TAG.mp4

Checklist

Tests have been added or updated to cover the changes
Documentation has been updated to reflect the changes
Code follows the established coding style guidelines
All tests are passing

…d persist tags on task creation

Copilot

Pull request overview

Adds inline validation to the task tag editor dialog to prevent empty/duplicate tags and allow comma-separated input, aligning the UX with issue #518.

Changes:

Added comma-separated parsing and multi-tag add support (_parseTags, _addTags).
Added inline form validation for empty input, spaces, and duplicates.
Updated tag selection chips to use the new multi-add path.

Comments suppressed due to low confidence (1)

lib/app/modules/detailRoute/views/tags_widget.dart:293

After moving validation into the TextFormField.validator, the try { ... } on FormatException block no longer appears to protect any code that can throw (and will likely leave validate.dart / loggy imports unused). Consider removing the try/catch here and cleaning up any now-unused imports to keep flutter analyze clean.

                    if (formKey.currentState!.validate()) {
                      try {
                        final tags = _parseTags(controller.text);
                        _addTags(tags);
                        Get.back();
                      } on FormatException catch (e, trace) {
                        logError(e, trace);
                      }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-09T18:05:18Z

lib/app/modules/detailRoute/views/tags_widget.dart

                      try {
-                        validateTaskTags(controller.text);
-                        _addTag(controller.text);
-                        // Navigator.of(context).pop();
+                        final tags = _parseTags(controller.text);
+                        _addTags(tags);
                        Get.back();
                      } on FormatException catch (e, trace) {


This change introduces new validation behavior (empty input, duplicates, comma-separated submission, and keeping the dialog open on invalid submit), but there are no widget tests covering it. Please add a widget test for TagsRoute that asserts inline errors are shown and that the dialog only closes when a valid tag (or tag list) is submitted.

Copilot · 2026-02-09T18:05:19Z

lib/app/modules/detailRoute/views/tags_widget.dart

+    draftTags ??= ListBuilder<String>();
+
+    for (final tag in tags) {
+      if (!draftTags!.build().contains(tag)) {


In _addTags, calling draftTags!.build() inside the loop allocates a new immutable list on every iteration. Use draftTags!.contains(tag) (ListBuilder supports contains) or build once before the loop / keep a Set for membership checks to avoid repeated allocations and quadratic behavior as tags grow.

Suggested change

if (!draftTags!.build().contains(tag)) {

if (!draftTags!.contains(tag)) {

Copilot · 2026-02-09T18:05:19Z

lib/app/modules/detailRoute/views/tags_widget.dart

                  validator: (value) {
-                    if (value != null) {
-                      if (value.isNotEmpty && value.contains(" ")) {
+                    final tags = _parseTags(value ?? '');
+
+                    if (tags.isEmpty) {
+                      return "Please enter a tag";
+                    }
+
+                    for (final tag in tags) {
+                      if (tag.contains(' ')) {
                        return "Tags cannot contain spaces";
                      }
+
+                      if (draftTags?.build().contains(tag) ?? false) {
+                        return "Tag already exists";
+                      }
                    }


The validator introduces hard-coded English error strings ("Please enter a tag", "Tags cannot contain spaces", "Tag already exists"), which bypasses the app’s localization approach via SentenceManager (e.g., sentences.tagAlreadyExists, sentences.tagShouldNotContainSpaces). Please switch these to localized SentenceManager(...).sentences entries, and add a new sentences key for the empty-input message so it’s translated consistently.

Copilot · 2026-02-09T18:05:19Z

lib/app/modules/detailRoute/views/tags_widget.dart

                        return "Tags cannot contain spaces";
                      }
+
+                      if (draftTags?.build().contains(tag) ?? false) {


draftTags?.build().contains(tag) in the validator has the same repeated-allocation issue as in _addTags. Prefer draftTags?.contains(tag) (or build once outside the loop) to avoid creating a new BuiltList during every validation pass (which can be triggered frequently while typing).

Suggested change

if (draftTags?.build().contains(tag) ?? false) {

if (draftTags?.contains(tag) ?? false) {

Pavel401 · 2026-02-10T05:51:49Z

Screen.Recording.2026-02-10.at.11.20.49.AM.mov

It's still there

SGI-CAPP-AT2 · 2026-02-10T06:21:03Z

Screen.Recording.2026-02-10.at.11.20.49.AM.mov
It's still there

@mulikruchi07 , Also check it with the Taskchampion type of Server
You can try changing server from profile page

Tag editor is not used there so you may need to implement it.

SGI-CAPP-AT2 · 2026-02-10T06:22:31Z

I was thinking to replace this tags editor with bottom sheet with only tag editor which is in add task bottom sheet

…date-clean

SGI-CAPP-AT2

I have added new tag editor and it serves the purpose of this PR

fix: validate empty/duplicate tags, support comma-separated input, an…

71a65e3

…d persist tags on task creation

Copilot AI review requested due to automatic review settings February 9, 2026 17:58

Copilot started reviewing on behalf of mulikruchi07 February 9, 2026 17:59 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

mulikruchi07 mentioned this pull request Feb 9, 2026

Fix: Inline validation for empty and duplicate tags in Tag Editor #519

Closed

4 tasks

This comment was marked as outdated.

Sign in to view

Merge remote-tracking branch 'upstream/main' into fix/tags-and-start-…

d59ba46

…date-clean

mulikruchi07 force-pushed the fix/tags-and-start-date-clean branch from d1be9ea to d59ba46 Compare February 11, 2026 15:58

SGI-CAPP-AT2 added 2 commits February 12, 2026 10:44

tag editor for tc task details added

d1e4313

addtags -> edit tags

426ca7c

SGI-CAPP-AT2 approved these changes Feb 12, 2026

View reviewed changes

SGI-CAPP-AT2 merged commit dd74e6f into CCExtractor:main Feb 12, 2026
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Inline validation for empty and duplicate tags in Tag Editor#586

fix: Inline validation for empty and duplicate tags in Tag Editor#586
SGI-CAPP-AT2 merged 4 commits intoCCExtractor:mainfrom
mulikruchi07:fix/tags-and-start-date-clean

mulikruchi07 commented Feb 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Pavel401 commented Feb 10, 2026

Uh oh!

SGI-CAPP-AT2 commented Feb 10, 2026

Uh oh!

SGI-CAPP-AT2 commented Feb 10, 2026

Uh oh!

This comment was marked as outdated.

SGI-CAPP-AT2 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

	if (!draftTags!.build().contains(tag)) {
	if (!draftTags!.contains(tag)) {

	if (draftTags?.build().contains(tag) ?? false) {
	if (draftTags?.contains(tag) ?? false) {

Conversation

mulikruchi07 commented Feb 9, 2026

Description

Fixes #518

Screenshots

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Pavel401 commented Feb 10, 2026

Uh oh!

SGI-CAPP-AT2 commented Feb 10, 2026

Uh oh!

SGI-CAPP-AT2 commented Feb 10, 2026

Uh oh!

This comment was marked as outdated.

SGI-CAPP-AT2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments