Repository navigation
Delete orphaned sidebar and inspector files in the starter overlay - #412
Merged
Merged
Conversation
templates/chat@bbe8cbf4 added AgentInspector.test.tsx, which imports ./AgentInspector, and sidebar-thread-state.ts, which only Sidebar.tsx uses. The overlay already deletes both parents, so sync typecheck failed with TS2307. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
I recall we wanted the agent to have some reference to go off of for the sidebar. I'm fine with merging this, but we should make a note to test the consistency of the sidebar when testing kyle's workspace skill |
BenGirone
approved these changes
Sep 30, 2026
Contributor
Author
|
@BenGirone if there is hesitation i am happy to close, this was something found when attempting a fix for the template sync failing. What do you prefer? |
Contributor
|
@mrkoreye more just thinking out loud 😅, these files in particular should be fine to delete an we have some instructions on sidebars in the front-end design skill anyway. should be good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync run 36644860440 failed typecheck with two TS2307s. Both files come from upstream and only exist for things the overlay already deletes:
app/components/layout/AgentInspector.test.tsximports./AgentInspector(deleted)app/lib/sidebar-thread-state.ts(+ its spec) is only used bySidebar.tsx(deleted), and imports a toolkit path that isn't in the published@agent-native/toolkit@0.23.1Adds all three to
delete.txt, same shape as #410. Previewed locally:apply.mjsis idempotent andpnpm typecheckpasses.Heads up: sync will still fail at
pnpm build(unknown utility class bg-background) until agent-native publishes toolkit0.198.0. That publish failed on a docs prerender error, being looked at separately.🤖 Generated with Claude Code