Show first-run role while onboarding loads

[steve8708]

Summary

• Render the first-run role step while the onboarding summary is still loading.
• Keep role selection visible if the summary fails, and keep later setup screens gated until profile data is available.
• Track the visible role step in onboarding analytics, without emitting duplicate start events when the summary resolves.

Validation

• FirstRunOnboarding and startup-gate specs: 63 passed.
• Toolkit typecheck passed.
• pnpm guards: all 89 checks passed.

[github-actions]

Visual recap — readback failed

The recap was published, but the workflow could not verify it. Screenshot capture was skipped. Open the interactive recap directly:

Open the full interactive recap

Diagnostic:

Published recap readback failed: get-visual-plan returned HTTP 403; the configured token cannot read this published recap

[builder-io-integration]

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

PR #7362 now also tracks the role step while the onboarding summary is unavailable. The component uses a stable readiness flag so the first-run role screen can emit onboarding_started and onboarding_step_viewed during loading or error, while the started-event ref prevents a duplicate start event when the profile resolves. The previous role-screen replacement concern is addressed, and the role selection remains in component state through the summary failure transition. Later setup screens remain gated until profile data is available.

Previous review feedback

• ✅ Role step replaced by summary error while entering a role: fixed and covered by a new spec.
• ✅ Missing role-step/start analytics during summary loading or failure: fixed; tests cover event emission and prevent a duplicate start event on resolution.

Two independent incremental reviews found no new confirmed bugs, security issues, or performance problems. One reviewer ran the focused component suite successfully (50/50); the PR description reports 63 relevant specs, toolkit typecheck, and all guards passing.

🧪 Browser testing: Skipped — the browser-test-planner agent is unavailable in this environment.