fix: drop ./ prefix from bin path so npm 11 keeps the executable - #17
Merged
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No related issue. The last publish attempt logged
"bin[canton-barebones]" script name bin/canton-barebones.js was invalid and removed— npm 11 (now installed inrelease.ymlfor trusted publishing) stripsbinentries whose path starts with./instead of just normalizing them like npm 10 did. Published like that, the package would ship without thecanton-barebonescommand.Changes
./prefix from thebinpath inpackage.jsonAcceptance criteria
canton-barebonesexecutable (npx @bootnodedev/cbn --helpworks)bin ... removedwarning in the publish logTest plan
Automated tests
No automated tests added;
npm testruns as the publish gate inrelease.yml.Manual verification
release.ymlpublishes via trusted publishing (OIDC)npm view @bootnodedev/cbn versionshows 0.1.3 andnpx @bootnodedev/cbn@latest statusresolves the binBreaking changes
None.
Checklist
Screenshots
None.