fix: normalize repo-wide file line endings to LF#807
Closed
ashwalk33r wants to merge 1 commit into
Closed
Conversation
Member
|
Please don't submit any automated / AI PRs to this repo. Thank you :) |
Author
yo bro wtf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/src/main/resourceExtensions/assets/minecraft/blockstates/conduit.jsonwas committed with CRLF (Windows) line endings. This normalizes it to LF, matching the rest of the resource files.All other files in the repo are fine, only that one had the issue.
Done with dos2unix https://linux.die.net/man/1/dos2unix
Why
The file's content is unchanged — only the line endings differ. Because the committed blob used CRLF, any edit on a Unix/WSL system rewrote it to LF, generating a confusing diff that shows all 6 lines removed and re-added with byte-identical text. Normalizing the endings removes this noise and prevents future churn between contributors on different platforms.
Changes
conduit.jsonfrom CRLF to LF line endings (no content change).Verification
git diff --ignore-all-spaceshows no differences (content is unchanged).grep -c $'\r'on the file returns 0 (no carriage returns remain).Notes
Other files in the repo may have the same CRLF/LF inconsistency in the future. A follow-up could add a
.gitattributesrule (e.g.*.json text eol=lf) to enforce LF and prevent this class of diff going forward.