Prevent PlaceholderAPI output from being evaluated as AdvancedCore JavaScript in reward commands - #285
Merged
BenCodez merged 1 commit intoAug 9, 2026
Conversation
BenCodez
deleted the
codex/propose-fix-for-papi-javascript-vulnerability
branch
August 9, 2026 00:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
[Javascript=...]expressions, which allowed attacker-influenced placeholder output to become executable script when the JavaScript engine was enabled.Description
replaceJavascriptOnlyhelpers forPlayerandOfflinePlayerinPlaceholderUtilsthat evaluate configured[Javascript=...]expressions without invokingPlaceholderAPIexpansion.MiscUtils.executeConsoleCommands(...)paths to call the newreplaceJavascriptOnlyfirst, then substitute internal reward placeholders withreplacePlaceHolder(...), and finally applyPlaceholderUtils.replacePlaceHolders(...)(PlaceholderAPI), ensuring placeholder output is not reinterpreted as script.PlaceholderUtilsTestthat assertsreplaceJavascriptOnlydoes not invokePlaceholderAPI.Testing
git diff --checkand staged/commit validations which passed.AdvancedCore/src/test/java/com/bencodez/advancedcore/tests/messages/PlaceholderUtilsTest.javato assert thatPlaceholderUtils.replaceJavascriptOnly(...)does not callPlaceholderAPI.mvn -Dtest=PlaceholderUtilsTest testbut the build could not complete because Maven failed to resolvemaven-resources-plugin:3.3.1from Maven Central (HTTP 403), so the unit test could not be executed in this environment.Codex Task