refactor: extract duplicated patterns into shared Card and Layout components#2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
- Create components/Card.tsx: reusable card with href, title, description props - Create components/Layout.tsx: reusable page wrapper with Head meta and footer - Refactor pages/index.tsx to use data-driven card rendering via map - Eliminates 4x repeated card markup pattern in index.tsx Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 4 card blocks in
pages/index.tsxwere identical in structure — onlyhref, title text, and description differed. The page also inlined the full<Head>/<main>/<footer>wrapper, which any new page would need to duplicate.What changed:
components/Card.tsx— typedCardProps { href, title, description }component replacing the repeated<a className={styles.card}>…</a>blocks.components/Layout.tsx— typedLayoutProps { title?, description?, children }component encapsulating<Head>,<main>, and the Vercel footer. Defaults mirror the original hard-coded values.pages/index.tsx— card data moved to acardsarray, rendered viacards.map(c => <Card key={c.href} {...c} />). Page wrapper replaced with<Layout>…</Layout>.Net effect:
index.tsxdrops from 72 to 51 lines; adding a new card or new page requires no copy-paste of boilerplate.Link to Devin session: https://app.devin.ai/sessions/dfa5372eed5e4dfe8bef318387f898b9
Requested by: @Bautisa46