Conversation
…'Lifecycle methods should not be empty'
Deploying main-page with
|
| Latest commit: |
db0e2b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7573fd26.main-page-3fk.pages.dev |
| Branch Preview URL: | https://fixerrorlint.main-page-3fk.pages.dev |
JGaviria0
left a comment
JGaviria0
left a comment
There was a problem hiding this comment.
I reviewed the changes in this PR and found a few things worth discussing. I left inline comments with details and suggested fixes.
| @@ -20,7 +20,8 @@ <h3 class=" text-lg md:text-xl font-bold text-primary"> | |||
| <div | |||
| class=" relative md:mx-12 mx-2 pb-12 before:absolute before:left-[-35px] before:block before:h-full before:border-l-2 before:border-black/20 dark:before:border-white/15 before:content-['']"> | |||
| <div class="relative pb-12 space-x-4 md:col-span-2 md:w-64 "> | |||
There was a problem hiding this comment.
I think there is a small template syntax issue here: there is no space between the (keydown) binding and role. That can make the template invalid or parsed incorrectly, so adding a space before role would make this safe.
| <div | ||
| class="relative pb-12 md:col-span-2 text-right space-x-4 justify-self-end md:w-64 mx-2"> | ||
| <div class=" hover:scale-110 duration-700 transition-transform cursor-pointer sticky top-0" *ngIf="i % 2 == 0" (click)="openModal(item)"> | ||
| <div class=" hover:scale-110 duration-700 transition-transform cursor-pointer sticky top-0" *ngIf="i % 2 === 0" (click)="openModal(item)" (keydown)="openModal(item)" role="button" aria-disabled="true"> |
There was a problem hiding this comment.
This keydown handler runs for any key press, so users navigating with keyboard arrows/tab could trigger the modal unintentionally. I’d suggest limiting this to Enter/Space (for example, (keydown.enter) and (keydown.space)) to keep behavior predictable.
| @@ -38,7 +38,10 @@ | |||
| <li | |||
| *ngFor="let theme of themes" | |||
| class="themes-menu-option px-2 py-1.5 cursor-default hover:bg-neutral-400/40 dark:hover:bg-gray-500/50 dark:text-gray-200 rounded-sm" | |||
There was a problem hiding this comment.
I think aria-disabled="true" conflicts with the current behavior because this element is still clickable and keyboard-actionable. For screen readers this can feel broken, so either remove aria-disabled or make the item truly disabled when that attribute is present.
2 participants
faltan solo los errores del tipado 'any' y el error de 'Lifecycle methods should not be empty'