Skip to content

moving to using dust_extinction models only#853

Open
karllark wants to merge 1 commit into
BEAST-Fitting:masterfrom
karllark:refactor_for_dust_extinction
Open

moving to using dust_extinction models only#853
karllark wants to merge 1 commit into
BEAST-Fitting:masterfrom
karllark:refactor_for_dust_extinction

Conversation

@karllark

Copy link
Copy Markdown
Member

Closes #259

@karllark karllark added the dust label Feb 27, 2026
@karllark

Copy link
Copy Markdown
Member Author

Slightly different results are due to dust_extinction likely that dust_extinction has a more correct implementation of the dust extinction models. This is causing the regression test to fail as expected. Provides a nice demonstration of why only having one place for the dust extinction models is the way to go. dust_extinction is much more extensively tested than what we had in the beast from back in the day.

@galaxyumi

Copy link
Copy Markdown
Contributor

Hi Karl, while I haven't closely reviewed this PR, I wanted to share a few initial thoughts. I completely agree with unifying the sources for the dust models and transitioning to a better-tested and well-maintained package! This will make the BEAST lighter and much easier to maintain moving forward. One feature I want to ensure we support is the ability to extend the dust extinction curves down to 54.4 eV (or 22.8 nm), either as an optional configuration from the BEAST side or by default from the dust_extinction package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider dust_extinction package

2 participants