refactor(kclshim): decouple Synthesize from stdin/stdout I/O#575
Open
refactor(kclshim): decouple Synthesize from stdin/stdout I/O#575
Conversation
Accept structured input parameter and return []client.Object instead of reading from stdin and writing to stdout. Add comprehensive tests with fixture-based KCL synthesizer covering deployment and service account assertions, and error handling for bad synthesizer input.
wonderyl
reviewed
Mar 5, 2026
wonderyl
reviewed
Mar 5, 2026
- Refactor kcl_test.go to use table-driven tests with simple if/else assertions - Remove unused Result and ResultResourceRef schemas from resource_list.k - Change KCL output type from ResourceList to object list ([any])
wonderyl
reviewed
Mar 6, 2026
Replace field-by-field assertions with JSON string comparison using normalizeWhitespace helper. Consolidate expectErr/errContains into a single expectedErrs field and add inline expectedOutput for success cases. Remove unused unstructured import.
wonderyl
approved these changes
Mar 6, 2026
ruinan-liu
reviewed
Mar 6, 2026
Collaborator
|
Overall looks good, just had some clarifying question regarding the new approach given it looks like breaking. Would you mind letting me know what is the motivation of this change? |
xiazhan
requested changes
Mar 6, 2026
ruinan-liu
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept structured input parameter and return []client.Object instead of reading from stdin and writing to stdout. Add comprehensive tests with fixture-based KCL synthesizer covering deployment and service account assertions, and error handling for bad synthesizer input.