Skip to content

Add test case to check LM reopen session scenario with max session limit#423

Open
v-akkalaria wants to merge 8 commits into
Azure:mainfrom
v-akkalaria:user/akash/reopen_session_tests
Open

Add test case to check LM reopen session scenario with max session limit#423
v-akkalaria wants to merge 8 commits into
Azure:mainfrom
v-akkalaria:user/akash/reopen_session_tests

Conversation

@v-akkalaria
Copy link
Copy Markdown

Adds test cases to verify that renegotiation-pending sessions are preserved during live migration when the session limit is reached, and fixes session count validation logic to allow reopening without counting against the limit.

Copilot AI review requested due to automatic review settings June 3, 2026 12:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds coverage and simulator support for reopening sessions after live migration, including preserving a renegotiation-pending session while the session table is at capacity.

Changes:

  • Added integration tests for (a) reopening a renegotiation-pending session while opening up to MAX_SESSIONS, and (b) invalid ReopenSession scenarios.
  • Updated the simulator vault to optionally skip session-limit enforcement when creating a physical session (used during reopen).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
ddi/mbor/types/tests/integration/reopen_session.rs Adds integration tests covering reopen-after-LM behavior at the session limit and invalid reopen cases.
ddi/mbor/sim/src/vault.rs Adds a flag to conditionally enforce MAX_SESSIONS when creating physical sessions; reopen path bypasses the check.

Comment thread ddi/mbor/sim/src/vault.rs
Comment thread ddi/mbor/sim/src/vault.rs Outdated
Comment thread ddi/mbor/types/tests/integration/reopen_session.rs
Comment thread ddi/mbor/types/tests/integration/reopen_session.rs Outdated
Comment thread ddi/mbor/types/tests/integration/reopen_session.rs Outdated
Copilot AI review requested due to automatic review settings June 4, 2026 03:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Comment thread ddi/mbor/sim/src/vault.rs
Comment thread ddi/mbor/types/tests/integration/reopen_session.rs
Comment thread ddi/mbor/types/tests/integration/reopen_session.rs Outdated
Comment thread ddi/mbor/types/tests/integration/reopen_session.rs Outdated
Comment thread ddi/mbor/types/tests/integration/reopen_session.rs Outdated
Copilot AI review requested due to automatic review settings June 4, 2026 05:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread ddi/mbor/types/tests/integration/reopen_session.rs Outdated
Comment thread ddi/mbor/types/tests/integration/reopen_session.rs
Comment thread ddi/mbor/sim/src/vault.rs
@v-akkalaria
Copy link
Copy Markdown
Author

@v-akkalaria please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

Copilot AI review requested due to automatic review settings June 5, 2026 09:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread ddi/mbor/sim/src/vault.rs
Comment thread ddi/mbor/sim/src/vault.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants