Add test case to check LM reopen session scenario with max session limit#423
Open
v-akkalaria wants to merge 8 commits into
Open
Add test case to check LM reopen session scenario with max session limit#423v-akkalaria wants to merge 8 commits into
v-akkalaria wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds coverage and simulator support for reopening sessions after live migration, including preserving a renegotiation-pending session while the session table is at capacity.
Changes:
- Added integration tests for (a) reopening a renegotiation-pending session while opening up to
MAX_SESSIONS, and (b) invalidReopenSessionscenarios. - Updated the simulator vault to optionally skip session-limit enforcement when creating a physical session (used during reopen).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| ddi/mbor/types/tests/integration/reopen_session.rs | Adds integration tests covering reopen-after-LM behavior at the session limit and invalid reopen cases. |
| ddi/mbor/sim/src/vault.rs | Adds a flag to conditionally enforce MAX_SESSIONS when creating physical sessions; reopen path bypasses the check. |
Author
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test cases to verify that renegotiation-pending sessions are preserved during live migration when the session limit is reached, and fixes session count validation logic to allow reopening without counting against the limit.