[test] Remove mock-specific resiliency backoff tuning#404
Open
mhatrevi wants to merge 1 commit into
Open
Conversation
Use the standard retry backoff constants for mock builds, increase the resiliency stress reset interval to match the longer timing, and remove the nextest serialization override for those stress tests.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes mock-only retry backoff tuning so mock builds use the same resiliency retry constants as non-mock builds, and adjusts stress-test/reset scheduling and nextest configuration accordingly.
Changes:
- Remove
cfg(feature = "mock")overrides for resiliency backoff base and jitter, standardizing on the 400ms/100ms constants. - Increase the mock resiliency stress Reset interval to align with the longer retry timing.
- Remove the nextest
ci-mockoverride that serialized resiliency stress tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| api/tests/src/resiliency/stress/tests.rs | Updates mock Reset interval used by resiliency stress tests (but leaves some stale documentation). |
| api/lib/src/resiliency.rs | Removes mock-specific backoff constants so retry timing matches the standard constants. |
| .config/nextest.toml | Removes the ci-mock serialization override previously applied to resiliency stress tests. |
Comment on lines
54
to
61
| /// Delay between Reset triggers (ms). | ||
| /// | ||
| /// Mock: the retry backoff base is 8 ms (see `BACKOFF_BASE_MS` in | ||
| /// `resiliency.rs` under `cfg(feature = "mock")`), and | ||
| /// `SessionNeedsRenegotiation` retries without backoff. | ||
| /// With 4 workers all serializing through `restore_partition`, | ||
| /// recovery completes quickly. 1 second is high enough for | ||
| /// recovery completes quickly. 3 seconds is high enough for | ||
| /// recovery to finish, but low enough that workers encounter |
| /// A uniform random value in `0..=BACKOFF_JITTER_MS` is added on top of | ||
| /// the exponential delay so that concurrent callers don't all retry at | ||
| /// exactly the same instant. | ||
| /// |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the standard retry backoff constants for mock builds, increase the resiliency stress reset interval to match the longer timing, and remove the nextest serialization override for those stress tests.