Skip to content

No-op: TBOR codec errors already use distinct DdiError variants#401

Draft
Copilot wants to merge 1 commit into
simplify-ddi-devfrom
copilot/fix-code-issue-based-on-review
Draft

No-op: TBOR codec errors already use distinct DdiError variants#401
Copilot wants to merge 1 commit into
simplify-ddi-devfrom
copilot/fix-code-issue-based-on-review

Conversation

Copilot AI commented May 27, 2026

Copy link
Copy Markdown
Contributor

This PR addresses the review comment requesting TBOR codec failures not be surfaced as MBOR failures. The targeted path in ddi/interface/src/error.rs already preserves TBOR-specific failure semantics, so no code changes were necessary.

  • Scope addressed

    • Confirmed the exact review target (discussion_r3295051552) maps TBOR encode failures to a TBOR-specific DdiError, not DdiError::MborError(MborError::EncodeError).
  • Current behavior (already in tree)

    • TBOR encode/decode conversion is explicit and codec-specific:
impl From<azihsm_ddi_tbor_codec::EncodeError> for DdiError {
    #[inline]
    fn from(_: azihsm_ddi_tbor_codec::EncodeError) -> Self {
        Self::TborEncodeError
    }
}

impl From<azihsm_ddi_tbor_codec::DecodeError> for DdiError {
    #[inline]
    fn from(_: azihsm_ddi_tbor_codec::DecodeError) -> Self {
        Self::TborDecodeError
    }
}

Copilot AI changed the title [WIP] Fix code as per review comment on PR 396 No-op: TBOR codec errors already use distinct DdiError variants May 27, 2026
Copilot AI requested a review from vsonims May 27, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants