test(e2e): add ENABLE_SECURE_TLS_BOOTSTRAPPING to E2E test config#8087
Merged
cameronmeissner merged 3 commits intomainfrom Mar 12, 2026
Merged
Conversation
cameronmeissner
requested review from
AbelHu,
Devinwong,
awesomenix,
calvin197,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
cameronmeissner
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an E2E configuration switch to control whether secure TLS bootstrapping is enabled during node bootstrapping, allowing test runs to fall back to bootstrap-token mode in environments where secure TLS bootstrapping can’t be enabled.
Changes:
- Add
ENABLE_SECURE_TLS_BOOTSTRAPPINGto the E2E env-based configuration model. - Gate
SecureTLSBootstrappingConfig.Enabledin e2e node bootstrapping config based on the new config flag (and VHD support). - Plumb a pipeline script variable intended to control this behavior in CI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| e2e/node_config.go | Uses E2E config flag to decide whether secure TLS bootstrapping is enabled (still respecting VHD support). |
| e2e/config/config.go | Adds EnableSecureTLSBootstrapping env var-backed config field. |
| .pipelines/scripts/e2e_run.sh | Introduces an ENABLE_SECURE_TLS_BOOTSTRAPPING variable intended for CI runs. |
lilypan26
approved these changes
Mar 12, 2026
awesomenix
approved these changes
Mar 12, 2026
cameronmeissner
deleted the
cameissner/stls/abe2e-bootstrapping-mode-config
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
adds the ability to specify whether secure TLS bootstrapping should be used within AgentBaker E2E testing - this allows partners who are running these tests in subscriptions where secure TLS bootstrapping can't be enabled to fall back to the standard bootstrap token-based bootstrapping mode if needed
Which issue(s) this PR fixes:
Fixes #