refactor(aztec-nr): rename conversion fns to encode_/decode_ naming#22576
Merged
nchamo merged 4 commits intomerge-train/fairiesfrom Apr 16, 2026
Merged
refactor(aztec-nr): rename conversion fns to encode_/decode_ naming#22576nchamo merged 4 commits intomerge-train/fairiesfrom
nchamo merged 4 commits intomerge-train/fairiesfrom
Conversation
nchamo
commented
Apr 15, 2026
Comment on lines
-2
to
-13
| // - le_bytes_31_to_fields | ||
| // - fields_to_be_bytes_31 | ||
| // - fields_to_le_bytes_31 | ||
| // - byte_to_bits | ||
| // - get_random_bits | ||
| // - get_chunks_of_random_bits | ||
| // - pad_31_byte_fields_with_random_bits | ||
| // - le_bytes_to_padded_fields | ||
| // - be_bytes_to_padded_fields | ||
| // | ||
| // If you need any of these functions, please check the PR linked below: | ||
| // https://github.com/AztecProtocol/aztec-packages/pull/12581 |
Contributor
Author
There was a problem hiding this comment.
Removed all of these
nchamo
commented
Apr 15, 2026
| /// | ||
| /// Each 31-byte chunk is interpreted as a big-endian integer and stored in a `Field`. For input `[1, 10, 3, ..., 0]` | ||
| /// (31 bytes), the resulting `Field` is `1 * 256^30 + 10 * 256^29 + 3 * 256^28 + ... + 0`. | ||
| pub(crate) fn encode_bytes_as_fields<let N: u32>(bytes: [u8; N]) -> [Field; N / 31] { |
Contributor
Author
There was a problem hiding this comment.
TODO per @nventuro :
- Make new functions public
- Add deprecation tag to old versions, suggesting to use the new ones
nventuro
approved these changes
Apr 15, 2026
| @@ -1,20 +1,21 @@ | |||
| // The following functions were removed as they were unused: | |||
Contributor
There was a problem hiding this comment.
Let's create an issue in the api renamings proj to rename this to encoding or whatever?
AztecBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #22580. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
BEGIN_COMMIT_OVERRIDE feat: check noir release has nargo binaries before releasing (#22551) chore: cache chainInfo in embeddedwallet (#22592) fix: wrap external getCapsule in transactionAsync (#22595) fix(pxe): throw clear error for invalid comparator in pick_notes (#22585) refactor(aztec-nr): rename conversion fns to encode_/decode_ naming (#22576) fix: adding transactions to PXE stores (#22603) feat: infrastructure for testing `[new_contract_artfiacts, old_aztec_stack]` (#22593) chore: fix unnecessary and inconsistent side-effect counter increments (#22245) feat(aztec-nr): new BoundedVec emit private log APIs (#22064) END_COMMIT_OVERRIDE
Thunkar
added a commit
that referenced
this pull request
Apr 17, 2026
BEGIN_COMMIT_OVERRIDE fix(pxe): cap event filter toBlock to last synced block (#22573) fix(pxe): round tx expiration timestamp to reduce precision (#22577) fix: eliminate anvil watcher warp race and false success logs (#22584) refactor: aztec new and init creating 2 crates (#20681) test: aztec new scaffold works (#20711) feat(cli): warning if contract crate has tests (#20723) feat(cli): auto-recompiling when aztec test is run (#20729) feat: aztec new supporting multiple contract crates (#21007) feat: asserts that aztec dep version matches cli (#21245) chore: backport aztec CLI improvements to v4-next (#22587) feat: check noir release has nargo binaries before releasing (#22551) chore: cache chainInfo in embeddedwallet (#22592) fix: wrap external getCapsule in transactionAsync (#22595) fix(pxe): throw clear error for invalid comparator in pick_notes (#22585) refactor(aztec-nr): rename conversion fns to encode_/decode_ naming (#22576) feat: infrastructure for testing `[new_contract_artfiacts, old_aztec_stack]` (#22593) chore: fix unnecessary and inconsistent side-effect counter increments (#22245) fix: update FaceID wallet redirects and strip anchors in redirect validation (#22505) docs: add getting started on testnet guide (#22366) docs: add getting started on testnet guide (backport #22366) (#22619) feat(aztec-nr): new BoundedVec emit private log APIs (#22064) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bytes_to_fields/bytes_from_fields/fields_to_bytes/fields_from_bytestoencode_/decode_form and split intobytes_as_fields.nrandfields_as_bytes.nr.pub(crate); external contracts continue to use the old names viapub usealiases inconversion.nr.aes128.nr,encoding.nrcomments,compressed_string.nrTODOs).Fixes F-364