feat: check noir release has nargo binaries before releasing#22551
Merged
benesjan merged 3 commits intomerge-train/fairiesfrom Apr 16, 2026
Merged
feat: check noir release has nargo binaries before releasing#22551benesjan merged 3 commits intomerge-train/fairiesfrom
benesjan merged 3 commits intomerge-train/fairiesfrom
Conversation
Contributor
Author
|
@ludamad do you know how to test this actually work without waiting for a release? |
Collaborator
|
You can use ci-release-pr |
benesjan
added
the
ci-release-pr
AztecBot
removed
the
ci-release-pr
benesjan
force-pushed
the
jb/check-noir-release-assets
branch
from
5f08939 to
f103f88
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
added
the
ci-release-pr
AztecBot
removed
the
ci-release-pr
Adds a pre-release check that verifies the noir GitHub release has nargo binary assets before proceeding with an aztec-packages release. This prevents releases that would cause 404 errors when users try to install nargo via noirup (as happened with v4.2.0-aztecnr-rc.2). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
benesjan
force-pushed
the
jb/check-noir-release-assets
branch
from
f103f88 to
2e20a94
Compare
benesjan
added
the
ci-release-pr
AztecBot
removed
the
ci-release-pr
Contributor
Author
|
|
Thunkar
approved these changes
Apr 16, 2026
AztecBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
## Summary - Adds a `check_noir_release_assets` function to root `bootstrap.sh` that queries the GitHub API to verify the noir release has nargo binary assets - Called from the `ci-release` case, right after semver validation and before the build starts -- so it fails fast and only runs during releases - Prevents releases like `v4.2.0-aztecnr-rc.2` where the noir tag existed but had no binaries, causing 404 errors when users ran `noirup` ## Test plan - [x] Verified `gh release view` query returns correct asset count against a known noir release (`v1.0.0-beta.3` → 5 assets) - [ ] CI passes Fixes https://linear.app/aztec-labs/issue/F-506/check-noir-binaries-exist-on-release --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #22580. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
BEGIN_COMMIT_OVERRIDE feat: check noir release has nargo binaries before releasing (#22551) chore: cache chainInfo in embeddedwallet (#22592) fix: wrap external getCapsule in transactionAsync (#22595) fix(pxe): throw clear error for invalid comparator in pick_notes (#22585) refactor(aztec-nr): rename conversion fns to encode_/decode_ naming (#22576) fix: adding transactions to PXE stores (#22603) feat: infrastructure for testing `[new_contract_artfiacts, old_aztec_stack]` (#22593) chore: fix unnecessary and inconsistent side-effect counter increments (#22245) feat(aztec-nr): new BoundedVec emit private log APIs (#22064) END_COMMIT_OVERRIDE
Thunkar
added a commit
that referenced
this pull request
Apr 17, 2026
BEGIN_COMMIT_OVERRIDE fix(pxe): cap event filter toBlock to last synced block (#22573) fix(pxe): round tx expiration timestamp to reduce precision (#22577) fix: eliminate anvil watcher warp race and false success logs (#22584) refactor: aztec new and init creating 2 crates (#20681) test: aztec new scaffold works (#20711) feat(cli): warning if contract crate has tests (#20723) feat(cli): auto-recompiling when aztec test is run (#20729) feat: aztec new supporting multiple contract crates (#21007) feat: asserts that aztec dep version matches cli (#21245) chore: backport aztec CLI improvements to v4-next (#22587) feat: check noir release has nargo binaries before releasing (#22551) chore: cache chainInfo in embeddedwallet (#22592) fix: wrap external getCapsule in transactionAsync (#22595) fix(pxe): throw clear error for invalid comparator in pick_notes (#22585) refactor(aztec-nr): rename conversion fns to encode_/decode_ naming (#22576) feat: infrastructure for testing `[new_contract_artfiacts, old_aztec_stack]` (#22593) chore: fix unnecessary and inconsistent side-effect counter increments (#22245) fix: update FaceID wallet redirects and strip anchors in redirect validation (#22505) docs: add getting started on testnet guide (#22366) docs: add getting started on testnet guide (backport #22366) (#22619) feat(aztec-nr): new BoundedVec emit private log APIs (#22064) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_noir_release_assetsfunction to rootbootstrap.shthat queries the GitHub API to verify the noir release has nargo binary assetsci-releasecase, right after semver validation and before the build starts -- so it fails fast and only runs during releasesv4.2.0-aztecnr-rc.2where the noir tag existed but had no binaries, causing 404 errors when users rannoirupTest plan
gh release viewquery returns correct asset count against a known noir release (v1.0.0-beta.3→ 5 assets)Fixes https://linear.app/aztec-labs/issue/F-506/check-noir-binaries-exist-on-release