Skip to content

fix(pxe): correct stale authwitness comment and inverted tagging error#22537

Merged
nchamo merged 1 commit intomerge-train/fairiesfrom
nc/fix-stale-authwitness-comment-and-inverted-error
Apr 17, 2026
Merged

fix(pxe): correct stale authwitness comment and inverted tagging error#22537
nchamo merged 1 commit intomerge-train/fairiesfrom
nc/fix-stale-authwitness-comment-and-inverted-error

Conversation

@nchamo
Copy link
Copy Markdown
Contributor

@nchamo nchamo commented Apr 14, 2026

Summary

Two findings from an AI audit of the PXE package:

  • Drop the stale "falls back to the local database" claim from getAuthWitness JSDoc; the implementation only checks transient witnesses.
  • Fix the inverted error message in load_private_logs_for_sender_recipient_pair: the check is aged > finalized, but the message said "lower than". The new message includes both values.

Fixes aztec-claude#329
Fixes aztec-claude#316

@nchamo nchamo self-assigned this Apr 14, 2026
@AztecBot
Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/2e12c941ab31d19c�2e12c941ab31d19c8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/rediscovery.test.ts (127s) (code: 0) group:e2e-p2p-epoch-flakes

@nchamo nchamo requested a review from mverzilli April 14, 2026 19:39
@nchamo nchamo merged commit 47e9e66 into merge-train/fairies Apr 17, 2026
12 checks passed
@nchamo nchamo deleted the nc/fix-stale-authwitness-comment-and-inverted-error branch April 17, 2026 10:53
@AztecBot
Copy link
Copy Markdown
Collaborator

✅ Successfully backported to backport-to-v4-next-staging #22580.

github-merge-queue bot pushed a commit that referenced this pull request Apr 17, 2026
BEGIN_COMMIT_OVERRIDE
fix(pxe): stop block synchronizer on PXE shutdown (#22604)
fix(aztec): respect TEST_ACCOUNTS env var in local network mode (#22600)
fix: check all aztec-nr dependency tags, not just aztec (#22483)
fix: reuse anchor block in kernel oracle (#22631)
refactor: unify contract compilation pipeline via bb aztec_process
(#22590)
fix(pxe): queue registerSender wipe to avoid racing with in-flight jobs
(#22623)
fix(pxe): bounds-check PropertySelector in pick_notes (#22614)
fix(pxe): guard private event store rollback against in-flight jobs
(#22615)
refactor(pxe): rename sideEffectCounter to initialSideEffectCounter
(#22599)
fix(pxe): correct stale authwitness comment and inverted tagging error
(#22537)
fix(aztec-nr): range-check auth witness fields before byte cast (#22624)
fix(pxe): serialize block stream event handling to prevent race
conditions (#22635)
fix(pxe): throw error on origin/contract address mismatch in simulation
(#22637)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants