fix: exclude poseidon v0.2.4 dependent tests from BB acir_tests#22402
Merged
TomAFrench merged 1 commit intobump-noirfrom Apr 8, 2026
Merged
fix: exclude poseidon v0.2.4 dependent tests from BB acir_tests#22402TomAFrench merged 1 commit intobump-noirfrom
TomAFrench merged 1 commit intobump-noirfrom
Conversation
The external poseidon library v0.2.4 calls poseidon2_permutation with 2 arguments but the current Noir nightly changed the signature to accept only 1 argument. These tests are already excluded in Noir's own CI (POSEIDON_COMPILE_FAILURE_EXECUTION_TESTS in nargo_cli/build.rs). Excluded tests: bench_2_to_17, no_predicates_numeric_generic_poseidon, poseidon_bn254_hash_width_3, poseidonsponge_x5_254, regression_5252, regression_5615, uhashmap
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the ACIR test build failure introduced by the Noir nightly update in #22393.
The external
poseidonlibrary v0.2.4 (https://github.com/noir-lang/poseidon) callsposeidon2_permutation(self.state, 4)with 2 arguments, but the current Noir nightly changed the stdlib signature to accept only 1 argument (poseidon2_permutation(input)). This causes 7 tests to fail compilation:bench_2_to_17no_predicates_numeric_generic_poseidonposeidon_bn254_hash_width_3poseidonsponge_x5_254regression_5252regression_5615uhashmapThese tests are already excluded in Noir's own CI (
POSEIDON_COMPILE_FAILURE_EXECUTION_TESTSintooling/nargo_cli/build.rs). This PR mirrors that exclusion in BB'sacir_tests/bootstrap.sh.The exclusions should be removed once the external poseidon library is updated to be compatible with the new API.
ClaudeBox log: https://claudebox.work/s/0ef46c61b9801d30?run=1