fix(node-lib): reuse existing fileStore in snapshot sync instead of recreating#22375
Open
danielntmd wants to merge 1 commit intomerge-train/spartanfrom
Open
fix(node-lib): reuse existing fileStore in snapshot sync instead of recreating#22375danielntmd wants to merge 1 commit intomerge-train/spartanfrom
danielntmd wants to merge 1 commit intomerge-train/spartanfrom
Conversation
…ecreating snapshotSync received a URL string and created a new ReadOnlyFileStore internally, discarding the one already created by the caller. Changed the function to accept a fileStore directly, so both trySnapshotSync and downloadEpochProvingJob pass their pre-created instances through. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PhilWindle
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snapshotSyncaccepted a URL string and created a newReadOnlyFileStoreinternally, discarding the instance already created by the caller. This resulted in redundant object instantiation during snapshot downloads.Changes
snapshotSyncto accept afileStore: ReadOnlyFileStoreinstead ofsnapshotsUrl: string, removing the redundantcreateReadOnlyFileStorecall inside the function.trySnapshotSyncto pass the pre-createdfileStorefrom each snapshot candidate.downloadEpochProvingJobto pass its already-createdfileStorethrough tosnapshotSync.