fix: videos in blog post didn't load when navigating to them within the#1063
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an Astro client-side navigation issue where <video> elements using child <source> tags don’t load when navigating to blog detail pages via the site router (as opposed to direct page loads).
Changes:
- Add a client-side navigation hook (
astro:after-swap) to force<video>source selection by callingvideo.load()for eagerly-sourced videos. - Update feature grid links to include a trailing slash.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/src/layouts/Base.astro | Adds reloadSwappedVideos() and runs it on astro:after-swap to ensure blog videos load after client-side navigation. |
| docs/src/layouts/partials/FeatureGrid.astro | Adds trailing slash to feature links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ngnijland
force-pushed
the
fix--video-load-on-navigation
branch
from
aa44312 to
86e52b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video's on the blog detail pages did not load when navigating to the pages via links within the website. They only loaded when directly navigating to the blog detail page.
The cause was that these
videoelements usesourceelements as child elements. On load a browser handles this by getting the src from the source and adding it to the video element. But after our first website load, JavaScript takes over, so this behavior stopped working after the first load. The fix is to manually load the video's on the Astroafter:page-swappedevent (replaces window load event).