Repository navigation
release: v0.5.0 - #123
release: v0.5.0#123
Conversation
A minor rather than the patch the section's size would suggest: it removes four exported symbols — `voice/openrouter.Config.CostTimeout`, `DefaultCostTimeout`, `DefaultSpeechModel` and `DefaultTranscribeModel` — and adds a public package, so `v0.x` calls it a minor. The upgrade notes name each one.
There was a problem hiding this comment.
Release-only changelog PR. I verified the mechanical parts against v0.4.1..HEAD:
[Unreleased]is renamed with today's UTC date (2026-11-14) and a new empty section sits above it.- The four named symbols (
Config.CostTimeout,DefaultCostTimeout,DefaultSpeechModel,DefaultTranscribeModel) really existed atv0.4.1and are gone at HEAD; a scan of the range found no other removed exported function, method, type, or constant. go.modwasgo 1.26.6atv0.4.1and isgo 1.26.11at HEAD, matching the notes.- The endpoint/map additions to
voice.VoiceRole,VoiceAttempt,TranscribeRole, andRolesConfigare additive and the zero values route exactly as before. - The
[0.5.0]link and the moved[Unreleased]compare link are correct, andscripts/release-notesextracts the new section (its tests pass).
One accuracy gap in the upgrade notes: callers who set voice/openrouter.Config.CostLookup do see different output, which is not listed. Otherwise the section is a faithful rename of [Unreleased] and there is nothing else significant to flag.
|
|
||
| - `voice/openrouter.Config.CostTimeout` and `voice/openrouter.DefaultCostTimeout` are removed. Speech | ||
| cost is now an estimate from the catalog, so there is no separate lookup to bound. Drop the field | ||
| and the constant; nothing else changes. |
There was a problem hiding this comment.
This says dropping CostTimeout changes nothing else, but callers who use Config.CostLookup get different results. In v0.4.1 the /generation lookup returned an all-null record for gen-tts-*, so Usage.CostUSD stayed 0 and CostSource was never set; at HEAD the same configuration returns runes * pricePerMillion / 1e6 with CostSource: "catalog". The ### Changed entry records the new estimate, but the upgrade notes (the part a consumer reads first, and what the PR summary calls the only caller-visible changes) omit it. Since cost_lookup defaults on for the front doors, this is visible from nova speak too. Add a bullet naming the new cost/CostSource values alongside the removed field.
|
pi-review reviewed |
There was a problem hiding this comment.
The only change since the previous review is four lines of upgrade notes in CHANGELOG.md for [0.5.0], closing the gap I raised about voice/openrouter.Config.CostLookup.
I checked the added text against the code and docs/DECISIONS.md D171:
CostLookupis still only a switch that fillsClip.Usage; the value is nowrunes * pricePerMillion / 1e6withCostSource: "catalog"(voice/openrouter/speak.go,cost.go), not the retired/generationlookup.- The
/generationsemantics in the note ("answered all nulls") matchdocs/VOICE.mdand testTestSpeak_A10_CostIsEstimatedFromTheCatalog. - Pin-endpoint pricing matches
pricePerMillion/pinnedProvider: a pin naming exactly one provider is read from the endpoint table, so the figure moves by the endpoint price ratio (A38), while a multi-name/orderpin falls back to the roster rate. go test ./scripts/release-notes/...still passes, so the section still extracts cleanly.
The release notes are now accurate for all four caller-visible items (the two removals, the Go floor, and CostLookup), plus the additive list. Nothing significant remains to flag.
release: v0.5.0
Renames
[Unreleased]to[0.5.0] - 2026-11-14, leaves a fresh empty[Unreleased], and moves the compare link tov0.5.0...HEAD.Minor, not a patch (as we discussed): the section removes four exported symbols and adds a public package, which
AGENTS.mdputs in the minor column forv0.x. Upgrade notes at the top of the section, in the order a consumer hits them:voice/openrouter.Config.CostTimeoutandDefaultCostTimeoutremoved — speech cost is a catalog estimate now, so there is no lookup to bound.voice/openrouter.DefaultSpeechModelandDefaultTranscribeModelremoved — a model always came from a role.net/http, reachable throughnova serve,provider/ssestreamandauth).voice.VoiceRole/VoiceAttempt/TranscribeRole/RolesConfig, and the newvoice/openai.I read every entry in the section rather than assuming: the two
voice/openrouterremovals and the Go floor are the only caller-visible breakages, and the rest is additive — the endpoint config, the release-gate work, the security/fuzz/nightly workflows, the provider pin, session naming, the resume hint, the two fuzz findings (#107,#108), the voice doc correction, and#57.make cigreen locally on this branch.On merge: tag the merge commit
v0.5.0onmainand push it, which starts the release workflow (acceptance for every chunk, four binaries, a release page). I will watch it and check the module resolves.