fix(autotune): flatten u/y arrays in apply_filters to fix ValueError#51
Open
DTSHNICK wants to merge 1 commit intoAuterion:masterfrom
Open
fix(autotune): flatten u/y arrays in apply_filters to fix ValueError#51DTSHNICK wants to merge 1 commit intoAuterion:masterfrom
DTSHNICK wants to merge 1 commit intoAuterion:masterfrom
Conversation
u and y were passed as 2D column vectors (shape (n,1)) from autotune.py, causing "setting an array element with a sequence" when initializing the 1D filter output arrays. Added np.ravel() at the start of apply_filters to normalize inputs to 1D.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
u and y were passed as 2D column vectors (shape (n,1)) from autotune.py, causing "setting an array element with a sequence" when initializing the 1D filter output arrays. Added np.ravel() at the start of apply_filters to normalize inputs to 1D.