Add interactive PID step response analysis window#43
Merged
mahima-yoga merged 10 commits intomasterfrom Oct 20, 2025
Merged
Conversation
mahima-yoga
changed the title
bresch
approved these changes
Oct 20, 2025
Collaborator
bresch
left a comment
bresch
left a comment
There was a problem hiding this comment.
Let's get that merged and improve it later as it doesn't interact with anything else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not yet super happy with the metrics (specifically overshoot), maybe we can remove displaying them for now and make a seperate PR for them when it's working reliably?
This PR introduces a new feature that allows users to visualize closed-loop step responses directly in the application. Metrics (rise time, settling time, overshoot, and steady-state error) are computed and displayed.
The step response is estimated by applying Wiener deconvolution to sliding windows of the measured input and output signals, producing multiple local impulse responses that are integrated to approximate the system’s step response. Outlier responses are filtered out. (Part of the) method is based on: https://github.com/PX4/flight_review/blob/main/app/plot_app/pid_analysis.py.
Displayed in plot: