Skip to content

Feature/react ojt project 3#3

Open
Aung-Thu-Hein wants to merge 17 commits into
mainfrom
feature/react-ojt-project-3
Open

Feature/react ojt project 3#3
Aung-Thu-Hein wants to merge 17 commits into
mainfrom
feature/react-ojt-project-3

Conversation

@Aung-Thu-Hein

Copy link
Copy Markdown
Owner

<< changes >>
add validation function

form-validation


url: Yup.string()
.matches(
/((https?):\/\/)?(www.)?[a-z0-9]+(\.[a-z]{2,}){1,3}(#?\/?[a-zA-Z0-9#]+)*\/?(\?[a-zA-Z0-9-_]+=[a-zA-Z0-9-%]+&?)?$/,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aung-Thu-Hein
ကိုယ်ရေးထားတဲ့ codeကို testing စစ်ပေးရင် ပိုကောင်းမယ်

phoneNumber: Yup
.string()
.matches(/^\d+$/, 'Enter number only')
.min(11, ({ min }) => `Invalid phone number`)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aung-Thu-Hein
testing စစ်ပေးရန်
testing စစ်တဲ့အချိန်မှာ invalid number, valid number ထည့်ပီ စစ်ပေးရန်

Comment thread src/components/ThirdOjtContent.js Outdated
email: "",
url: "",
phoneNumber: "",
empty: true,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty က ဘာအတွက်လိုအပ်တာလဲ

</Form.Group>
<Form.Group className='form-field'>
<Label labelName="Phone Number" />
<Stack>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question]
<Stack> က ဘာအတွက်သုံးတာလဲ

Comment thread src/components/ThirdOjtContent.js Outdated
</Stack>
</Form.Group>
<Form.Group className="form-field button-field">
<Button buttonName="Cancle" />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancle ကန်ကလီ :D
မှားနေကျ စကားလုံး

Cancelနှိပ်ရင် ဘာလုပ်ပေးမှာလဲ testingစစ်ပါ

</Form.Group>
<Form.Group className="form-field button-field">
<Button buttonName="Cancle" />
<Button buttonName="Confirm" isDisabled={!isValid} />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmကို clickရင် လုပ်တဲ့ အလုပ်ကို testing စစ်ပါ

Comment thread src/App.js
import logo from './logo.svg';
import React from 'react';
import Header from './components/Header';
import Content from './components/ThirdOjtContent';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import တွေကို ..sorting စီပါ

Comment thread src/App.css Outdated
text-align: center;
font-size: 20px;
color: white;
background-color: rgb(138, 23, 71);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

color မှာ white ကိုသုံးပီး
bg colorမှာ rgb နဲ့သုံးတယ် . .မျိုးစုံဖြစ်နေလို့ . .ကိုယ်သုံးမှာကို .. တမျိုးတည်းပုံသေသတ်မှတ်ရင်ပိုကောင်းမယ်

Comment thread src/components/ThirdOjtContent.js Outdated

name: Yup
.string()
.required("Name is required"),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msg တွေကို common ထုတ်ရေးကြည့်ပေးပါ
{attribute} is required လို ကြေငြာထားပီး ပြန်အစားထိုးတဲ့ပုံစံနဲ့ ရေးပါ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants