photoproc: chdir() reduces overhead syscalls and kernel context switches#370
Open
GermanAizek wants to merge 1 commit intoAtoptool:masterfrom
Open
photoproc: chdir() reduces overhead syscalls and kernel context switches#370GermanAizek wants to merge 1 commit intoAtoptool:masterfrom
GermanAizek wants to merge 1 commit intoAtoptool:masterfrom
Conversation
More details valgrind massif memory analysis in pull request description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminating chdir and using full file paths improved performance collect metrics (photoproc) by reducing the number of system calls and kernel context switches.
I also noticed that it reduced RAM consumption by another -100kb. Although initially I was thinking optimizing atop info proc collection time.
More details my valgrind massif memory analysis:
Before commit e6efd27:
After commit 572ef61: