Skip to content

Conversation

@KATO-Hiro
Copy link
Collaborator

@KATO-Hiro KATO-Hiro commented Feb 1, 2026

close #3120

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for ACL Beginner and ACL Contest 1 contests.
    • Added six new ACL Contest 1 problems (A–F): Reachable Towns, Sum is Multiple, Moving Pieces, Keep Distances, Shuffle Window, and Center Rearranging.
  • Documentation

    • Enhanced implementation guide with pre-implementation checklist, expanded test-driven development guidance, and clarified design patterns for contest providers.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Feb 1, 2026

Walkthrough

The pull request extends the contest management system to support ACL Beginner and ACL Contest 1 by introducing new provider classes, registering contest type mappings, adding problem task data, and establishing comprehensive test coverage for these new contest providers.

Changes

Cohort / File(s) Summary
Contest Type System
src/lib/utils/contest.ts, src/test/lib/utils/test_cases/contest_type.ts
Added acl1 contest prefix mapping to ARC_LIKE category and corresponding test case to verify proper contest classification.
Provider Implementation
src/lib/utils/contest_table_provider.ts
Introduced two new provider classes (ACLBeginnerProvider, ACLProvider) filtering by contest_id abl and acl1 respectively; reorganized ACL provider grouping to consolidate legacy AclPractice with new providers into unified Acl group.
Problem Data
prisma/tasks.ts
Added six new ACL1 problem tasks (acl1_a through acl1_f) with contest metadata and problem indices, covering problems A–F with associated titles and names.
Test Coverage
src/test/lib/utils/contest_table_provider.test.ts, src/test/lib/utils/test_cases/contest_table_provider.ts, src/test/lib/utils/test_cases/contest_type.ts
Extended test suite with dedicated test cases and mock data for ACLBeginnerProvider and ACLProvider, including filtering logic validation, metadata verification, and table generation scenarios.
Documentation
docs/guides/how-to-add-contest-table-provider.md
Updated implementation guide with pre-implementation checklist phase, expanded TDD guidance, detailed pattern tables for three implementation patterns, and augmented sections on complex multi-concept providers with edge-case considerations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 New contests hop into view,
ACL courses, both fresh and true!
Providers dance in organized rows,
With tests that bloom and data that flows,
The table grows richer, as our guide shows! 📚✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the primary changes: adding new ACL-related contest entries and updating the ACL table documentation and configuration.
Linked Issues check ✅ Passed The PR implements the requested feature to add ARC-like related contests to the ACL table by introducing ACLBeginnerProvider, ACLProvider, and corresponding test coverage.
Out of Scope Changes check ✅ Passed All changes are directly related to adding and updating ACL table functionality; no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch #3120

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator Author

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit 9f53e70 into staging Feb 1, 2026
4 checks passed
@KATO-Hiro KATO-Hiro deleted the #3120 branch February 1, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] テーブル「ACL」に AxC-like の関連コンテストを追加しましょう

2 participants