-
-
Notifications
You must be signed in to change notification settings - Fork 10
chore: Remove ABL from ABC-like table (#3108) #3121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request removes the ACL Beginner Contest (ABL) from the ABC-like contest table. ABCLikeProvider now explicitly excludes ABL via a conditional check, contest documentation is updated with revised counts, and test data and assertions are modified to reference Zone2021 contests and updated contest identifiers instead of ABL. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/guides/how-to-add-contest-table-provider.md`:
- Around line 219-224: Update the table row for "ABC-Like" to explicitly state
that ABL is shown under ACL Practice, e.g. change the cell text that currently
reads "あり(14個)、ABL は ACL と同じ区分で表示" to a clearer phrase like "あり(14個) — ABL は ACL
Practice に表示(ABC-Like ではありません)" so readers understand ABL has moved to ACL
Practice rather than remaining under ABC-Like; update any nearby explanatory
text referencing "ABL" or "ACL" to use the exact term "ACL Practice" for
clarity.
In `@src/lib/utils/contest_table_provider.ts`:
- Around line 468-474: The ABCLikeProvider currently excludes 'abl' in
ABCLikeProvider.setFilterCondition() (the "contestId !== 'abl'" check) which
causes ABL to disappear; remove that special-case exclusion so ABCLikeProvider
includes contests where classifyContest(contestId) === this.contestType (i.e.,
delete the "contestId !== 'abl'" clause in
ABCLikeProvider.setFilterCondition()), and run tests or check
ACLPracticeProvider.setFilterCondition() and classifyContest() to ensure no
other provider or classification logic is meant to own 'abl'.
🧹 Nitpick comments (1)
src/test/lib/utils/contest_table_provider.test.ts (1)
1461-1514: Add an explicit assertion thatablis excluded.
The allowed list still includes'abl', so a regression could pass. Add a direct expectation to enforce the new behavior.✅ Suggested test hardening
const filtered = provider.filter(taskResultsForABCLikeProvider); expect(filtered.length).toBeGreaterThan(0); + expect(filtered.some((task) => task.contest_id === 'abl')).toBe(false); expect( filtered.every((task) => { const contestId = task.contest_id;
KATO-Hiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #3108
Summary by CodeRabbit
Documentation
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.