refactor: extract validation and path logic to utils module#121
Open
pocikode wants to merge 1 commit into
Open
refactor: extract validation and path logic to utils module#121pocikode wants to merge 1 commit into
pocikode wants to merge 1 commit into
Conversation
Moved scattered validation logic from command files into: - utils/paths.py: get_tasks_file() - utils/validation.py: validate_description(), validate_task_file(), validate_task_id() All command files (add, list, done) now import from utils instead of defining their own validation functions. Reduces duplication and makes validation logic easier to test and maintain. Fixes ApexOpsStudio#3
Author
|
/claim #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Extracted duplicated validation logic from the command files into two utility modules:
utils/paths.py—get_tasks_file()(was copy-pasted in all 3 command files)utils/validation.py—validate_description(),validate_task_file(),validate_task_id()The command files now import from utils. Same behavior, less duplication, easier to test.