[vkucera]

Fixes C-style, redundant, wrong, and dangerous casts (found by Clang-Tidy and cpplint).

• Remove redundant casts. (readability-redundant-casting)
• Remove const_cast. (cppcoreguidelines-pro-type-const-cast)
• Replace C-style casts with static_cast. (google-readability-casting, cpplint: readability/casting)
• Replace unsafe C-style casts with dynamic_cast. (cppcoreguidelines-pro-type-cstyle-cast)
• Replace static_cast in downcasts with dynamic_cast. (cppcoreguidelines-pro-type-static-cast-downcast)
• Replace reinterpret_cast with static_cast or dynamic_cast. (cppcoreguidelines-pro-type-reinterpret-cast)
• Replace two-step casting through void* with reinterpret_cast. (bugprone-casting-through-void)

[github-actions]

O2 linter results: ❌ 0 errors, ⚠️ 6044 warnings, 🔕 37 disabled

[vkucera]

Dear code owners, the PR is ready for review.
Please note that PWGEM/Dilepton/Utils/MomentumSmearer.h contains invalid casts from TH1D to TH1F which are marked with FIXME comments.

[vkucera]

Oops, this does not look right.

[alibuild]

Error while checking build/O2Physics/code-check for 5d5dc38 at 2026-11-04 11:33:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 5 errors and 1050 warnings.'
Found 5 errors and 1050 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/72b807b39c8743919f1b3c8728232e35f6aef1c3/O2Physics-code-check/errors.txt
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx:303:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx:1245:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/Tasks/matchingMFT.cxx:216:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/Utils/ElectronModule.h:390:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/Utils/ElectronModule.h:415:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
++ [[ 1050 -gt 0 ]]
++ cat /sw/BUILD/72b807b39c8743919f1b3c8728232e35f6aef1c3/O2Physics-code-check/warnings.txt
PWGEM/Dilepton/Core/DielectronCut.h:485:8: warning: function 'DielectronCut::SetMindEtadPhi' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:78:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:101:8: warning: constructor does not initialize these fields: ccdb, mRunNumber, d_bz [cppcoreguidelines-pro-type-member-init]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:326:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:354:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:355:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:371:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:372:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:388:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:389:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:406:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:407:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:463:39: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:464:43: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:465:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:501:15: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:510:22: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:728:9: warning: if with identical then and else branches [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:758:105: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:857:9: warning: if with identical then and else branches [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:891:105: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1035:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1041:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1137:24: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1164:39: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1364:7: warning: if with identical then and else branches [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1393:105: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1414:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:82:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
[0 more errors; see full log]

Full log here.

[mhemmer-cern]

@vkucera is this ready for review again with the latest commit?