Skip to content

[PWGCF] Net charge fluctuations3#16229

Draft
pravatp98 wants to merge 13 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3
Draft

[PWGCF] Net charge fluctuations3#16229
pravatp98 wants to merge 13 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3

Conversation

@pravatp98
Copy link
Copy Markdown
Contributor

@pravatp98 pravatp98 commented May 13, 2026

Addition event pilup cuts has been added, also some changes has been made for efficiency correction

@pravatp98
Efficiency Correction added
2f570eb
@pravatp98
Remove commented-out track QA functions
2bd91c1 
Removed commented-out code for various track quality assessment functions and their calls, streamlining the nchCumulantsId.cxx file.
@pravatp98
Remove unused track identification variables
bd2b742 
Removed unused variables related to electron and deuteron track identification.
@pravatp98
Add configurable parameters for charge histograms
42b9c74
@pravatp98
Merge branch 'AliceO2Group:master' into NetChargeFluctuations3
e0eef10
@pravatp98
Merge branch 'AliceO2Group:master' into NetChargeFluctuations3
7c2ea78
@pravatp98
Rename file and update includes in nchCumulantsId.cxx
bae294b 
additional Event cuts has been added
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@github-actions github-actions Bot added the pwgcf label May 13, 2026
@github-actions github-actions Bot changed the title Net charge fluctuations3 [PWGCF] Net charge fluctuations3 May 13, 2026
pravatp98 added 2 commits May 13, 2026 12:22
@pravatp98
Refactor conditional checks for particle types
c5d1c10 
additional checks has been added
@pravatp98
Add string header to nchCumulantsId.cxx
574598e 
Additional checks has been added
@alibuild alibuild mentioned this pull request May 13, 2026
Closed
@pravatp98
Move vector include to a new line
e781be7 
Additional checks has been added
@pravatp98
Copy link
Copy Markdown
Contributor Author

pravatp98 commented May 13, 2026

Dear @victor-gonzalez , @SwatiSaha-1997 ,
The error for one failing check is not coming due to my code. Kindly review and approve the PR
Thanks and Regards
Pravata

SwatiSaha-1997
SwatiSaha-1997 previously approved these changes May 13, 2026
View reviewed changes
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 13, 2026

Dear @victor-gonzalez , @SwatiSaha-1997 , The error for one failing check is not coming due to my code. Kindly review and approve the PR Thanks and Regards Pravata

Which check are you referring to?

@pravatp98
Copy link
Copy Markdown
Contributor Author

pravatp98 commented May 13, 2026

Dear @vkucera
Screenshot from 2026-05-13 14-11-19
build/O2Physics/o2/macOS
build/O2Physics/o2/macOS-arm these two in short o2/macOS and o2/macOS-arm, there errors in these two not due to my code. Kindly Review and approve the PR

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 13, 2026

there errors in these two not due to my code. Kindly Review and approve the PR

What makes you think that the macOS-arm build is not failing because of your changes?

@vkucera vkucera marked this pull request as draft May 13, 2026 11:27
pravatp98 added 2 commits May 13, 2026 17:18
@pravatp98
Merge branch 'AliceO2Group:master' into NetChargeFluctuations3
660ec7b
@pravatp98
Remove unused track identification variables
200a765 
Removed unused variables related to electron and deuteron track identification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwatiSaha-1997 SwatiSaha-1997 SwatiSaha-1997 left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@isputows isputows Awaiting requested review from isputows isputows is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pravatp98 @vkucera @SwatiSaha-1997