[PWGCF] FemtoUniverse -- Improve K0Short histogramming. by a-m-andrushko · Pull Request #16222 · AliceO2Group/O2Physics

a-m-andrushko · 2026-05-12T15:25:40Z

Improve yesterday's commit by simplifying K0Short histogramming.

github-actions · 2026-05-12T15:27:00Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

alibuild · 2026-05-12T15:35:21Z

Error while checking build/O2Physics/staging for f88e918 at 2026-05-12 17:35:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-05-12T15:38:33Z

Error while checking build/O2Physics/o2 for f88e918 at 2026-05-12 17:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-05-12T15:46:24Z

Error while checking build/O2Physics/staging for 78a0451 at 2026-05-12 17:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:526:11: error: expected '}' before 'else'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:523:9: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:523:12: error: suggest explicit braces to avoid ambiguous 'else' [-Werror=dangling-else]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-05-12T15:50:57Z

Error while checking build/O2Physics/o2 for 78a0451 at 2026-05-12 17:50:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:526:11: error: expected '}' before 'else'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:523:9: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:523:12: error: suggest explicit braces to avoid ambiguous 'else' [-Werror=dangling-else]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-05-12T16:03:27Z

Error while checking build/O2Physics/o2 for f236a96 at 2026-05-12 18:03:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:526:13: error: expected '}' before 'else'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-05-12T16:05:04Z

Error while checking build/O2Physics/staging for f236a96 at 2026-05-12 18:05:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:526:13: error: expected '}' before 'else'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-05-12T16:44:26Z

Error while checking build/O2Physics/o2 for 2afcf28 at 2026-05-12 18:44:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-05-12T16:47:48Z

Error while checking build/O2Physics/staging for 2afcf28 at 2026-05-12 18:47:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2026-05-12T16:50:21Z

@a-m-andrushko I converted your PR to a draft because of the compilation warnings. Why did you mark it as ready for review again?

a-m-andrushko · 2026-05-12T17:07:35Z

@a-m-andrushko I converted your PR to a draft because of the compilation warnings. Why did you mark it as ready for review again?

Sorry, my bad, I misclicked thinking it was a merge conflict error, I am working on the errors.

a-m-andrushko · 2026-05-13T14:25:41Z

@vkucera, I do not understand why the builds are "waiting for status to be reported", they never started since yesterday, am I supposed to push it as "Ready for review" first?

vkucera · 2026-05-13T14:44:25Z

@vkucera, I do not understand why the builds are "waiting for status to be reported", they never started since yesterday, am I supposed to push it as "Ready for review" first?

Yes, if you have fixed all compilation warnings.

alibuild · 2026-05-13T15:36:03Z

Error while checking build/O2Physics/staging for 175f5d4 at 2026-05-13 17:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2026-05-13T15:41:28Z

Your PR failed again. How did you check the compilation warnings?

a-m-andrushko · 2026-05-13T17:08:58Z

Your PR failed again. How did you check the compilation warnings?

I pushed too many versions yesterday and lost track of the current version that I had locally, I made a mistake, sorry; now, everything is built properly, but when it comes to build/O2Physics/o2/macOS, it is a recurring issue, I have experienced this fail during a few recent PRs.

a-m-andrushko added 4 commits May 4, 2026 17:14

Add hInvMassK0Short to helicity analysis

9cf21c8

Add extra histos

8e4fd6f

Add extra histos and fix some O2 linter errors

0dc6c86

Add fake K0Short histograms

35cd3d0

a-m-andrushko requested review from alibuild, lauraser, lgraczykCern, otonvd, prchakra, shouqiye and victor-gonzalez as code owners May 12, 2026 15:25

github-actions Bot added the pwgcf label May 12, 2026

a-m-andrushko force-pushed the hInvMassK0Short_fake_improved branch from f88e918 to e326226 Compare May 12, 2026 15:40

alibuild mentioned this pull request May 12, 2026

Please consider the following formatting changes to #16222 a-m-andrushko/O2Physics#14

Closed

a-m-andrushko force-pushed the hInvMassK0Short_fake_improved branch from 78a0451 to aaeb1d4 Compare May 12, 2026 15:57

vkucera marked this pull request as draft May 12, 2026 16:27

a-m-andrushko force-pushed the hInvMassK0Short_fake_improved branch from f236a96 to a889d49 Compare May 12, 2026 16:38

a-m-andrushko marked this pull request as ready for review May 12, 2026 16:38

vkucera marked this pull request as draft May 12, 2026 16:49

prchakra previously approved these changes May 12, 2026

View reviewed changes

Merge branch 'AliceO2Group:master' into hInvMassK0Short_fake_improved

9e172c4

a-m-andrushko and others added 6 commits May 12, 2026 19:23

Improve K0Short histogramming

b8e9de6

Improve K0Short histogramming

e326226

Improve K0Short histogramming

aaeb1d4

Improve K0Short histogramming

a889d49

Merge branch 'master' into hInvMassK0Short_fake_improved

2afcf28

Trigger CI

b99ac0b

a-m-andrushko marked this pull request as ready for review May 13, 2026 15:25

vkucera marked this pull request as draft May 13, 2026 15:38

Fix build errors

3b22026

a-m-andrushko dismissed prchakra’s stale review via 3b22026 May 13, 2026 15:41

a-m-andrushko force-pushed the hInvMassK0Short_fake_improved branch from 175f5d4 to 3b22026 Compare May 13, 2026 15:41

a-m-andrushko marked this pull request as ready for review May 13, 2026 15:48

prchakra enabled auto-merge (squash) May 13, 2026 17:50

prchakra approved these changes May 13, 2026

View reviewed changes

prchakra merged commit 88fbe9a into AliceO2Group:master May 13, 2026
13 of 14 checks passed

Conversation

a-m-andrushko commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented May 12, 2026

Uh oh!

alibuild commented May 12, 2026

Uh oh!

alibuild commented May 12, 2026

Uh oh!

alibuild commented May 12, 2026

Uh oh!

alibuild commented May 12, 2026

Uh oh!

alibuild commented May 12, 2026

Uh oh!

alibuild commented May 12, 2026

Uh oh!

alibuild commented May 12, 2026

Uh oh!

vkucera commented May 12, 2026

Uh oh!

a-m-andrushko commented May 12, 2026

Uh oh!

a-m-andrushko commented May 13, 2026

Uh oh!

vkucera commented May 13, 2026

Uh oh!

alibuild commented May 13, 2026

Uh oh!

vkucera commented May 13, 2026

Uh oh!

a-m-andrushko commented May 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented May 12, 2026 •

edited

Loading