Skip to content

[PWGHF] Added THn for QA of electrons from Z#16216

Closed
sashingo wants to merge 72 commits into
AliceO2Group:masterfrom
sashingo:master
Closed

[PWGHF] Added THn for QA of electrons from Z#16216
sashingo wants to merge 72 commits into
AliceO2Group:masterfrom
sashingo:master

Conversation

@sashingo
Copy link
Copy Markdown
Contributor

  • added THn for QA of electrons from Z
  • reduced ConfigurableAxis

sashingo and others added 30 commits July 7, 2025 14:35
correct minor typo in the parameter detail
- change the parameter name 
-- ptZeeCorrfac => correctionPtElectron
- fixed a typo
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
@github-actions github-actions Bot added the pwghf PWG-HF label May 12, 2026
@github-actions github-actions Bot changed the title Added THn for QA of electrons from Z [PWGHF] Added THn for QA of electrons from Z May 12, 2026
@github-actions
Copy link
Copy Markdown

O2 linter results: ❌ 5 errors, ⚠️ 2 warnings, 🔕 1 disabled

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 12, 2026

Why is this 72 commits long?

@vkucera vkucera marked this pull request as draft May 12, 2026 12:30
@sashingo
Copy link
Copy Markdown
Contributor Author

I don't know why.
I committed as usual. (add, commit, push)

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 12, 2026

I don't know why. I committed as usual. (add, commit, push)

But you are not updating and developing the right way.

  • You develop in the master branch. You shouldn't.
  • You keep merging the upstream into your master branch instead of rebasing. Like this you just keep cumulating merge commits and every PR you make will have more and more commits.
  • There is no reason why your PR should contain your commits since last July.

Btw, fix the errors and warnings before you make the PR ready for review.

@sashingo sashingo closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

2 participants