Skip to content

[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model#2143

Open
NarrowsProjects wants to merge 5 commits intomainfrom
impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel
Open

[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model#2143
NarrowsProjects wants to merge 5 commits intomainfrom
impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 23, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Setting filters will now display them in the url

Notable changes for developers:

  • All filters now have a normalized setter that will set the values of the filters based on the output of the normalize getter in query parameter form.

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Apr 23, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 23, 2026
@NarrowsProjects NarrowsProjects changed the base branch from main to feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url April 23, 2026 15:10
@NarrowsProjects NarrowsProjects changed the title Impov/o2 b 1555/add normalize setter functions to all classes that extend filter model and selection model [O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.92%. Comparing base (ca5d12b) to head (bc70145).

Files with missing lines Patch % Lines
...blic/components/common/selection/SelectionModel.js 0.00% 17 Missing ⚠️
...onents/Filters/RunsFilter/MagnetsFilteringModel.js 0.00% 9 Missing ⚠️
.../Filters/common/filters/ProcessedTextInputModel.js 0.00% 5 Missing ⚠️
...ponents/Filters/RunsFilter/EorReasonFilterModel.js 0.00% 4 Missing ⚠️
.../Filters/RunsFilter/MultiCompositionFilterModel.js 0.00% 4 Missing ⚠️
...s/common/filters/NumericalComparisonFilterModel.js 0.00% 4 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 4 Missing ⚠️
...ponents/Filters/RunsFilter/DetectorsFilterModel.js 0.00% 3 Missing ⚠️
...ic/components/Filters/RunsFilter/GaqFilterModel.js 0.00% 3 Missing ⚠️
...nts/Filters/RunsFilter/RunDefinitionFilterModel.js 0.00% 3 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
- Coverage   45.95%   45.92%   -0.03%     
==========================================
  Files        1036     1035       -1     
  Lines       17155    17166      +11     
  Branches     3118     3124       +6     
==========================================
  Hits         7883     7883              
- Misses       9272     9283      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch 11 times, most recently from e540f27 to edb626f Compare April 27, 2026 07:04
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url branch from 4a30d27 to ae6c287 Compare April 27, 2026 07:17
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch 2 times, most recently from 88cc4f4 to 49ed030 Compare April 27, 2026 07:36
Base automatically changed from feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url to main May 5, 2026 10:02
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch from 49ed030 to 85beaac Compare May 5, 2026 10:11
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch from 85beaac to 02fec07 Compare May 6, 2026 09:04
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch from 02fec07 to bc70145 Compare May 6, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant