Conversation
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the library version from 15.0.0 to 15.0.1 across Adyen/settings.py, VERSION, and setup.py. A review comment identifies a version inconsistency with pyproject.toml and recommends consolidating the version number into a single source of truth to improve maintainability and prevent future build issues.
| name="Adyen", | ||
| packages=find_packages(include=["Adyen*"], exclude=["tests", "tests.*"]), | ||
| version="15.0.0", | ||
| version="15.0.1", |
There was a problem hiding this comment.
The version is being updated here to 15.0.1, but it's inconsistent with pyproject.toml, which specifies version = "14.0.0". This file seems to have been missed in the previous release as well.
This inconsistency can lead to incorrect package metadata and build issues, as different tools might read the version from different files. Please update the version in pyproject.toml to 15.0.1.
For better long-term maintainability, I recommend consolidating the version number into a single source of truth. The VERSION file is a good candidate. You can configure setup.py and pyproject.toml to read the version from this file, which would prevent future inconsistencies.
2 participants
Merged pull requests to be released:
Full Changelog: v15.0.0...main