Repository navigation
feat: add Prefix, a code cut off after a segment - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prefix is a postcode cut off after one of its segments, such as the district
EK-01-A03. It names every code that starts with it, so it is the value to group or select records by: state, LGA, district, or area. Until now the libraries only produced a prefix as a string.spec/vectors.jsongains cases for parsing a prefix, for which codes it contains, and for its parent. All four languages run them.through(its last segment), take itsparent, ask whether itcontainsa code, and cut a code down withtruncate. A whole code is the narrowest prefix.truncateas the name: it mirrorsdate_truncin SQL anddt.truncatein dataframes, which is how the people who will group by place already think. The existingprefix()keeps returning a string, since changing it would quietly break comparisons in Python and JavaScript.Nothing is released by this. Java will need 0.3.0 when it is, because the new error is a case on the sealed
ParseError, which breaks an exhaustiveswitchin a caller's code. Rust's enum is non-exhaustive, so the crate does not break.