Extract a pluggable, multi-instance-safe RateLimitStore abstraction - #369
Open
NkechiOgbuji wants to merge 1 commit into
Open
Extract a pluggable, multi-instance-safe RateLimitStore abstraction#369NkechiOgbuji wants to merge 1 commit into
NkechiOgbuji wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #307
Description
This PR refactors the rate limiting implementation by introducing a pluggable
RateLimitStoreabstraction, separating the token-bucket algorithm from its storage implementation.The default behavior remains unchanged through an in-memory store, while making it straightforward to introduce a shared backend (such as Redis) for multi-instance or serverless deployments without modifying the core rate-limiting logic.
Linked Issue
Closes #307
Type of Change
Changes Made
RateLimitStoreabstraction to decouple storage from the token-bucket algorithm.InMemoryRateLimitStoreas the default implementation to preserve existing behavior.rateLimitRequestto work with an injected store while maintaining backward compatibility.Validation
git diff --checkreports no whitespace or merge-marker issues.Notes
This refactor preserves the existing rate-limiting behavior and public API while providing a clean extension point for future shared storage implementations. No new dependencies were introduced.