lance-graph-ogar: rustfmt the six bridge files — #1202 left a stray blank line in each - #1204
Conversation
…lank line in each My defect in #1202, and it turned q2's fmt gate red the moment #1202 landed on main. Deleting each `pub const NAMESPACE` block left two consecutive blank lines where the doc-comment had been; `cargo fmt` removes one per file, six lines total, no other change. I verified #1202 with clippy and tests and never ran `cargo fmt` on the crate. Earlier in the same session I checked fmt explicitly for every other crate I touched; here I did not, and the gate I had just spent the day building is what caught it. It also corrects a measurement I published in that PR and in q2's workflow comment: I claimed `cargo fmt --all` does NOT reach `[patch]`-replaced sibling sources, having observed that `lance-graph-contract`'s drift produced no diff. q2's run reports all six of these files by absolute path (`/home/runner/work/q2/q2/lance-graph/crates/lance-graph-ogar/src/bridges/*.rs`), so it plainly does reach this crate. Whatever distinguishes the two cases, the general claim was too strong for the single observation behind it. Verified: rustfmt --check clean on all six, clippy 0 errors, tests 96 passed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (6)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe Redmine bridge now uses the OGAR-backed ChangesBridge alias cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change removes stray blank lines in bridge files and is ready to merge with no current material risk identified. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d4b511bc-a395-4a9b-980c-f4fa8d3bfde3) |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
My defect in #1202, caught by the gate #146 was built to turn on.
What happened
Deleting each
pub const NAMESPACEblock in #1202 left two consecutive blank lines where the doc-comment had been.cargo fmtremoves one per file — six lines, no other change.The moment #1202 landed on
main, q2'sRustfmt (check)went red, reporting exactly these six files:Why I missed it
I verified #1202 with
cargo clippyandcargo testand never rancargo fmton the crate. Earlier in the same session I checked formatting explicitly for every other crate I touched — including measuring pre-existing drift before deciding whether to reformat — and here I simply didn't.It also corrects a measurement I published
In #1202's body and in q2's workflow comment I wrote that
cargo fmt --alldoes not reach[patch]-replaced sibling sources, on the strength of one observation:lance-graph-contractcarried real drift and produced no diff.q2's run reports all six of these files by absolute path under
.../q2/lance-graph/crates/lance-graph-ogar/, so it plainly does reach this crate. Whatever distinguishes the two cases — and I have not established what does — the general claim was too strong for the single observation behind it. The q2-side comment is being corrected in #146.Verification
Unblocks
AdaWorldAPI/q2#146, which is red on this and nothing else.🤖 Generated with Claude Code
https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V
Summary by CodeRabbit
Refactor
Bug Fixes
Tests