Skip to content

lance-graph-ogar: rustfmt the six bridge files — #1202 left a stray blank line in each - #1204

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/ogar-bridges-fmt
Sep 6, 2026
Merged

lance-graph-ogar: rustfmt the six bridge files — #1202 left a stray blank line in each#1204
AdaWorldAPI merged 1 commit into
mainfrom
claude/ogar-bridges-fmt

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Sep 6, 2026

Copy link
Copy Markdown
Owner

My defect in #1202, caught by the gate #146 was built to turn on.

What happened

Deleting each pub const NAMESPACE block in #1202 left two consecutive blank lines where the doc-comment had been. cargo fmt removes one per file — six lines, no other change.

The moment #1202 landed on main, q2's Rustfmt (check) went red, reporting exactly these six files:

Diff in /home/runner/work/q2/q2/lance-graph/crates/lance-graph-ogar/src/bridges/medcare_bridge.rs:...
Diff in .../odoo_bridge.rs   Diff in .../openproject_bridge.rs
Diff in .../redmine_bridge.rs Diff in .../smb_bridge.rs Diff in .../woa_bridge.rs

Why I missed it

I verified #1202 with cargo clippy and cargo test and never ran cargo fmt on the crate. Earlier in the same session I checked formatting explicitly for every other crate I touched — including measuring pre-existing drift before deciding whether to reformat — and here I simply didn't.

It also corrects a measurement I published

In #1202's body and in q2's workflow comment I wrote that cargo fmt --all does not reach [patch]-replaced sibling sources, on the strength of one observation: lance-graph-contract carried real drift and produced no diff.

q2's run reports all six of these files by absolute path under .../q2/lance-graph/crates/lance-graph-ogar/, so it plainly does reach this crate. Whatever distinguishes the two cases — and I have not established what does — the general claim was too strong for the single observation behind it. The q2-side comment is being corrected in #146.

Verification

rustfmt --check  (all six)   → clean
cargo clippy --manifest-path crates/lance-graph-ogar/Cargo.toml --all-targets → 0 errors
cargo test  --manifest-path crates/lance-graph-ogar/Cargo.toml → 96 passed, 0 failed

Unblocks AdaWorldAPI/q2#146, which is red on this and nothing else.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V

Summary by CodeRabbit

  • Refactor

    • Standardized healthcare and Redmine bridge behavior using shared bridge infrastructure.
    • Healthcare and Redmine bridge types are now deprecated in favor of port-based class identification.
    • The Redmine codebook remains available through a deprecated compatibility reference.
  • Bug Fixes

    • Improved fallback handling for unknown concepts and registry-based resolution.
    • Temporary-directory cleanup now completes reliably without bypassing resource cleanup.
  • Tests

    • Expanded coverage for namespace registration, identity, aliases, class resolution, seeded contexts, and fallback errors.

…lank line in each

My defect in #1202, and it turned q2's fmt gate red the moment #1202 landed on
main. Deleting each `pub const NAMESPACE` block left two consecutive blank
lines where the doc-comment had been; `cargo fmt` removes one per file, six
lines total, no other change.

I verified #1202 with clippy and tests and never ran `cargo fmt` on the crate.
Earlier in the same session I checked fmt explicitly for every other crate I
touched; here I did not, and the gate I had just spent the day building is what
caught it.

It also corrects a measurement I published in that PR and in q2's workflow
comment: I claimed `cargo fmt --all` does NOT reach `[patch]`-replaced sibling
sources, having observed that `lance-graph-contract`'s drift produced no diff.
q2's run reports all six of these files by absolute path
(`/home/runner/work/q2/q2/lance-graph/crates/lance-graph-ogar/src/bridges/*.rs`),
so it plainly does reach this crate. Whatever distinguishes the two cases, the
general claim was too strong for the single observation behind it.

Verified: rustfmt --check clean on all six, clippy 0 errors, tests 96 passed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 11399d65-01f7-4b66-bb08-5d25c6330ef3

📥 Commits

Reviewing files that changed from the base of the PR and between aba3672 and 64ca8e5.

📒 Files selected for processing (6)
  • crates/lance-graph-ogar/src/bridges/medcare_bridge.rs
  • crates/lance-graph-ogar/src/bridges/odoo_bridge.rs
  • crates/lance-graph-ogar/src/bridges/openproject_bridge.rs
  • crates/lance-graph-ogar/src/bridges/redmine_bridge.rs
  • crates/lance-graph-ogar/src/bridges/smb_bridge.rs
  • crates/lance-graph-ogar/src/bridges/woa_bridge.rs
💤 Files with no reviewable changes (6)
  • crates/lance-graph-ogar/src/bridges/openproject_bridge.rs
  • crates/lance-graph-ogar/src/bridges/odoo_bridge.rs
  • crates/lance-graph-ogar/src/bridges/woa_bridge.rs
  • crates/lance-graph-ogar/src/bridges/smb_bridge.rs
  • crates/lance-graph-ogar/src/bridges/redmine_bridge.rs
  • crates/lance-graph-ogar/src/bridges/medcare_bridge.rs

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The Redmine bridge now uses the OGAR-backed UnifiedBridge<RedminePort> alias and retains a deprecated compatibility codebook export. SMB and WOA receive whitespace-only formatting changes.

Changes

Bridge alias cleanup

Layer / File(s) Summary
Redmine OGAR alias and compatibility export
crates/lance-graph-ogar/src/bridges/redmine_bridge.rs
RedmineBridge now aliases UnifiedBridge<RedminePort>. REDMINE_CODEBOOK remains as a deprecated compatibility export.
SMB and WOA formatting
crates/lance-graph-ogar/src/bridges/smb_bridge.rs, crates/lance-graph-ogar/src/bridges/woa_bridge.rs
Whitespace before the test modules was adjusted. Runtime behavior is unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 64ca8

This change removes stray blank lines in bridge files and is ready to merge with no current material risk identified.

Poem

A rabbit checks the bridge at night
Redmine hops to OGAR light
SMB keeps its spacing neat
WOA lands on tidy feet
The codebook rests, the tests stay bright

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the six bridge files and the rustfmt blank-line cleanup described in the pull request objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 6, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_d4b511bc-a395-4a9b-980c-f4fa8d3bfde3)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 6, 2026 12:04
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@AdaWorldAPI
AdaWorldAPI merged commit d3a3387 into main Sep 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants