Trap more bad_alloc for input images#633
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves robustness of the CLI image loading path by catching allocation-related failures (notably new[]/image allocation paths) when image dimensions come from user-controlled input, preventing abrupt termination on out-of-memory scenarios.
Changes:
- Wrap KTX/DDS surface buffer allocations and
alloc_image()calls in exception handling to trap allocation failures. - Add a top-level exception trap around the selected loader call in
load_ncimage(). - Refactor loader/storer descriptor tables to use named function-pointer typedefs and spec structs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures bad_alloc for cases where
new[]is driven by allocations trigged by user-defined images, which could be malicious.