Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
c8b18fa to
cf917cc
Compare
|
🤖 Hi @gagika, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @gagika, but I was unable to process your request. Please see the logs for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements Z-loss to improve numerical stability and prevent runaway logits. Alongside techniques like QK-normalization and logit soft-capping, it is a key mechanism for stabilizing low-precision (BF16/FP8) training.
Key Changes:
z_loss_multiplierparameter totypes.py(defaults to0.0).max_utils.cross_entropy_with_logits) into the standard training loop (loss_fn) and the vocabulary tiling path (vocab_tiling_linen_loss).auxdictionary and logged to TensorBoard aslearning/z_loss.Tests
test_cross_entropy_with_z_lossinmax_utils_test.pyto verify the penalty calculation is mathematically correct.test_vocab_tiling_gradient_with_z_lossintiling_test.pyto ensure loss and gradients match exactly between standard and vocabulary-tiled computations when Z-loss is enabled.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.